[Synthetics UI] Prefer custom_heartbeat_id to monitor.id for Uptime detail link when present
#143128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
bug
|
Pinging @elastic/uptime (Team:uptime) |
dominiqueclarke
approved these changes
Oct 11, 2022
| @@ -118,6 +118,7 @@ export const LastTenTestRuns = () => { | |||
| }, | |||
| ]; | |||
|
|
|||
| const historyIdParam = monitor?.custom_heartbeat_id ?? monitor?.id; | |||
There was a problem hiding this comment.
Suggestion
Suggested change
| const historyIdParam = monitor?.custom_heartbeat_id ?? monitor?.id; | |
| const historyIdParam = monitor?.[ConfigKey.CUSTOM_HEARTBEAT_ID] ?? monitor?.id; |
There was a problem hiding this comment.
++ I need to get used to relying on these!
|
@elasticmachine merge upstream |
justinkambic
force-pushed
the
143016/fix-link-to-uptime-detail-view-for-lightweight-project-monitor-custom-heartbeat-ids
branch
from
58e3f04 to
c751d83
Compare
justinkambic
force-pushed
the
143016/fix-link-to-uptime-detail-view-for-lightweight-project-monitor-custom-heartbeat-ids
branch
from
c751d83 to
87f061f
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 19, 2022
…me detail link when present (elastic#143128) * Prefer `custom_heartbeat_id` to `monitor.id` when present. * Prefer `ConfigKey`. (cherry picked from commit c25eedc)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #143016.
We link to the Uptime detail link from the Synthetics last 10 runs view. Unfortunately, when there's a custom heartbeat ID, our view is not resilient to this. Uptime UI utilizes the custom ID for its queries, so we need to account for this as long as we are linking to that UI.