[Terminal Output] Truncated process output msg #143304

mitodrummer · 2022-10-13T16:43:39Z

Summary

Ansi crafted message added to tty player when a process exceeds max_kilobytes_per_process advanced policy setting. [ VIEW POLICIES ] inline link will navigate to /security/administration/policy page. Permissions are checked to ensure only users who can access the management page see the link.

xterm updated to v5, which unlocks ansi hyperlink escape codes. Some breaking changes were fixed in the process.
#141179 <-- xterm renovate PR

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

…curity policies page.

opauloh · 2022-10-13T19:09:19Z

...urity_solution/public/timelines/components/timeline/session_tab_content/use_session_view.tsx

@@ -224,6 +225,8 @@ export const useSessionView = ({
 const { globalFullScreen } = useGlobalFullScreen();
 const { timelineFullScreen } = useTimelineFullScreen();

+ const { canAccessEndpointManagement } = useUserPrivileges().endpointPrivileges;


Didn't know about this one, nice!

What does using the canAccessEndpointManagement accomplish?

The ansi message will contain a link to /security/administration/policy which is a listing of the defend integration policies. Only users with this permission can access it. I'm passing it as a parameter since I can't import this hook into session_view as it would introduce a circular dependency.

...ins/session_view/public/components/tty_player_controls/tty_player_controls_markers/index.tsx

x-pack/plugins/session_view/public/components/tty_player/translations.ts

x-pack/plugins/session_view/public/components/tty_player/hooks.ts

opauloh

LGTM / minor comments

…-ref HEAD~1..HEAD --fix'

…into truncated_output_msg

…-fix'

…into truncated_output_msg

kibana-ci · 2022-10-25T23:44:17Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 2cb1590

Failed CI Steps

Security Solution Tests #4

Test Failures

[job] [logs] Security Solution Tests #4 / Timeline search and filters Update kqlMode for timeline "before all" hook for "should be able to update timeline kqlMode with filter"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`sessionView`	102	104	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	9.5MB	9.6MB	+318.0B
`sessionView`	454.5KB	379.1KB	-75.3KB
total			-75.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`sessionView`	48.8KB	48.9KB	+108.0B

History

💔 Build #82666 failed 36a4651
💔 Build #82591 failed 989b63b
💛 Build #81145 was flaky f3fa5af
💚 Build #80829 succeeded 9670ebe
💚 Build #80325 succeeded 25792d5
💔 Build #80323 failed 2c4be48

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2022-10-25T23:48:06Z

💔 All backports failed

Status	Branch	Result
❌	8.5	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 143304

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2022-10-26T23:51:42Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 143304 locally

Karl Godard added 6 commits October 12, 2022 16:04

xterm updated to v5. initial work done for max kb warning msg

81c5d71

Merge branch 'main' into truncated_output_msg

1c4b3e5

max bytes exceeded msg implemented, along with authz gated link to se…

184d4f9

…curity policies page.

marker indication on max bytes exceeded fixed

977f337

tests written

277fdd7

tests written

f0edcad

mitodrummer added release_note:enhancement Team: AWP: Visualization AWP team that does most fullstack work in kibana v8.5.1 labels Oct 13, 2022

mitodrummer requested a review from a team October 13, 2022 16:43

mitodrummer requested a review from a team as a code owner October 13, 2022 16:43

opauloh reviewed Oct 13, 2022

View reviewed changes

...ins/session_view/public/components/tty_player_controls/tty_player_controls_markers/index.tsx Outdated Show resolved Hide resolved

opauloh reviewed Oct 13, 2022

View reviewed changes

x-pack/plugins/session_view/public/components/tty_player/translations.ts Outdated Show resolved Hide resolved

opauloh reviewed Oct 13, 2022

View reviewed changes

x-pack/plugins/session_view/public/components/tty_player/translations.ts Outdated Show resolved Hide resolved

opauloh reviewed Oct 13, 2022

View reviewed changes

x-pack/plugins/session_view/public/components/tty_player/hooks.ts Outdated Show resolved Hide resolved

opauloh approved these changes Oct 13, 2022

View reviewed changes

Karl Godard and others added 2 commits October 13, 2022 12:52

fixed a bug where an active search would prevent normal playback/seeking

84629c6

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

05d58ee

…-ref HEAD~1..HEAD --fix'

Omolola-Akinleye self-requested a review October 13, 2022 20:25

Karl Godard and others added 8 commits October 13, 2022 14:52

updates per review comments

b8dd4ab

Merge branch 'truncated_output_msg' of github.com:mitodrummer/kibana …

0d88ff2

…into truncated_output_msg

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

06b1fbe

…-fix'

fixed text

6fa3d7a

Merge branch 'truncated_output_msg' of github.com:mitodrummer/kibana …

2c4be48

…into truncated_output_msg

fixed ts error

1188458

fix to scroll hack

25792d5

Merge branch 'main' into truncated_output_msg

9670ebe

mitodrummer requested a review from kqualters-elastic October 17, 2022 23:14

mitodrummer added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Oct 18, 2022

mitodrummer and others added 2 commits October 18, 2022 11:32

Merge branch 'main' into truncated_output_msg

f3fa5af

Merge branch 'main' into truncated_output_msg

989b63b

kqualters-elastic approved these changes Oct 25, 2022

View reviewed changes

mitodrummer enabled auto-merge (squash) October 25, 2022 18:52

mitodrummer added 2 commits October 25, 2022 14:43

Merge branch 'main' into truncated_output_msg

36a4651

Merge branch 'main' into truncated_output_msg

2cb1590

mitodrummer merged commit 97a68d8 into elastic:main Oct 25, 2022

kibanamachine added the v8.6.0 label Oct 25, 2022

kibanamachine mentioned this pull request Oct 26, 2022

Update ftr (main) #143010

Merged

1 task

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 26, 2022

mitodrummer deleted the truncated_output_msg branch October 26, 2022 23:57

mitodrummer added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 26, 2022

kibanamachine mentioned this pull request Nov 3, 2022

Update dependency react-hook-form to ^7.38.0 (main) #143996

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Terminal Output] Truncated process output msg #143304

[Terminal Output] Truncated process output msg #143304

mitodrummer commented Oct 13, 2022 •

edited by kibanamachine

Loading

opauloh Oct 13, 2022

Omolola-Akinleye Oct 13, 2022

mitodrummer Oct 13, 2022

opauloh left a comment

kibana-ci commented Oct 25, 2022

kibanamachine commented Oct 25, 2022

kibanamachine commented Oct 26, 2022

[Terminal Output] Truncated process output msg #143304

[Terminal Output] Truncated process output msg #143304

Conversation

mitodrummer commented Oct 13, 2022 • edited by kibanamachine Loading

Summary

Checklist

opauloh Oct 13, 2022

Choose a reason for hiding this comment

Omolola-Akinleye Oct 13, 2022

Choose a reason for hiding this comment

mitodrummer Oct 13, 2022

Choose a reason for hiding this comment

opauloh left a comment

Choose a reason for hiding this comment

kibana-ci commented Oct 25, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

kibanamachine commented Oct 25, 2022

💔 All backports failed

Manual backport

Questions ?

kibanamachine commented Oct 26, 2022

mitodrummer commented Oct 13, 2022 •

edited by kibanamachine

Loading