Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test: printablePdfV2 allows width and height to have decimal, and others #143873

Merged
merged 4 commits into from
Nov 4, 2022
Merged

Fix failing test: printablePdfV2 allows width and height to have decimal, and others #143873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
52feea3
comment test suites for flaky
tsullivan Nov 3, 2022
3bae9ca
test2
tsullivan Nov 3, 2022
3f4a173
ilm test cleanup
tsullivan Nov 3, 2022
46a649b
restore
tsullivan Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions x-pack/test/reporting_api_integration/reporting_and_security/ilm_migration_apis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,16 @@ export default function ({ getService }: FtrProviderContext) {
await runMigrate(); // ensure that the ILM policy exists for the first test
});

after(async () => {
await reportingAPI.teardownLogs();
});

afterEach(async () => {
await reportingAPI.deleteAllReports();
await runMigrate(); // ensure that the ILM policy exists
});

after(async () => {
await reportingAPI.teardownLogs();
await reportingAPI.makeAllReportingIndicesUnmanaged(); // ensure that a delete phase does not remove the index while future tests are running
});

it('detects when no migration is needed', async () => {
expect(
await reportingAPI.checkIlmMigrationStatus(
Expand Down
3 changes: 1 addition & 2 deletions x-pack/test/reporting_api_integration/reporting_and_security/validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ export default function ({ getService }: FtrProviderContext) {
}
};

// Failing: See https://github.com/elastic/kibana/issues/143717
describe.skip('Job parameter validation', () => {
describe('Job parameter validation', () => {
before(async () => {
await reportingAPI.initEcommerce();
});
Expand Down