Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] add in product help for layer group drag and drop instructions #144259

Merged
merged 10 commits into from
Nov 2, 2022
Merged

[Maps] add in product help for layer group drag and drop instructions #144259

Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fc607b0
[Maps] add in product help for layer group drag and drop instructions
nreese Oct 31, 2022
b0d5e7e
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine Oct 31, 2022
ce6f28a
render callout above panel
nreese Oct 31, 2022
2e2cef4
Merge branch 'main' into layer_group_callout
kibanamachine Nov 1, 2022
a52394c
review feedback on copy
nreese Nov 1, 2022
b70379e
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine Nov 1, 2022
7019c03
Update x-pack/plugins/maps/public/connected_components/edit_layer_pan…
nreese Nov 2, 2022
d39ba0e
Update x-pack/plugins/maps/public/connected_components/edit_layer_pan…
nreese Nov 2, 2022
a18f47c
Update x-pack/plugins/maps/public/connected_components/edit_layer_pan…
nreese Nov 2, 2022
7c79756
update title
nreese Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions ...ugins/maps/public/connected_components/edit_layer_panel/layer_settings/layer_settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

import React, { ChangeEvent, Fragment } from 'react';
import {
EuiCallOut,
EuiText,
EuiTitle,
EuiPanel,
EuiFormRow,
Expand Down Expand Up @@ -242,8 +244,44 @@ export function LayerSettings(props: Props) {
);
};

const renderLayerGroupInstructions = () => {
return isLayerGroup(props.layer) ? (
<>
<EuiCallOut
title={i18n.translate('xpack.maps.layerPanel.settingsPanel.layerGroupCalloutTitle', {
defaultMessage: 'Use drag and drop to populate layer group',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about "Drag layers in and out of the group" for the title?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, lets use that title.

})}
iconType="layers"
>
<EuiText>
<ul>
<li>
{i18n.translate('xpack.maps.layerPanel.settingsPanel.layerGroupAddToFront', {
defaultMessage: 'To add your first layer, drag it onto the group name',
})}
</li>
<li>
{i18n.translate('xpack.maps.layerPanel.settingsPanel.layerGroupAddToPosition', {
defaultMessage:
'To add another layer, drag it anywhere above the last layer in the group',
})}
</li>
<li>
{i18n.translate('xpack.maps.layerPanel.settingsPanel.layerGroupRemove', {
defaultMessage: 'To remove a layer, drag it above or below the group',
})}
</li>
</ul>
</EuiText>
</EuiCallOut>
<EuiSpacer size="m" />
</>
) : null;
};

return (
<Fragment>
{renderLayerGroupInstructions()}
<EuiPanel>
<EuiTitle size="xs">
<h5>
Expand Down