Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Updates the UI copy for Random sampling #144265

Merged
merged 2 commits into from
Nov 9, 2022
Merged

[Lens] Updates the UI copy for Random sampling #144265

merged 2 commits into from
Nov 9, 2022

Conversation

KOTungseth
Copy link
Contributor

Summary

Updates the Random sampling copy.

Original PR: #143929

@KOTungseth KOTungseth added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This commit does not require backporting ui-copy Review of UI copy with docs team is recommended v8.6.0 labels Oct 31, 2022
@KOTungseth KOTungseth requested a review from dej611 October 31, 2022 18:33
@KOTungseth KOTungseth self-assigned this Oct 31, 2022
@KOTungseth KOTungseth requested a review from a team as a code owner October 31, 2022 18:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

stratoula
stratoula approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me :) LGTM!

@KOTungseth
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB -20.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @KOTungseth

@KOTungseth KOTungseth merged commit 64c3c63 into elastic:main Nov 9, 2022
@KOTungseth KOTungseth deleted the lens/sampling-text branch November 9, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@mbondyra mbondyra mbondyra approved these changes

@dej611 dej611 dej611 approved these changes

Assignees

@KOTungseth KOTungseth

Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure ui-copy Review of UI copy with docs team is recommended v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@KOTungseth @elasticmachine @kibana-ci @dej611 @mbondyra @stratoula @kibanamachine