Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Failing test: X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/spaces_only/tests/alerting/builtin_alert_types/index_threshold/alert·ts - alerting api integration spaces only Alerting builtin alertTypes index_threshold rule runs correctly: avg all #144266

Merged
merged 8 commits into from
Nov 7, 2022

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Oct 31, 2022

Resolves #142335

Summary

This test failed very infrequently. It looks like the test was updated in this PR to also test that the index threshold gracefully handles ES errors, so it was testing two different things. I split this out into two separate tests in case they were interfering with each other somehow and increased the lookback for the average all test

Flaky test runner:

@ymao1 ymao1 force-pushed the flaky-test-index-thresh-avg-all branch from 9a9e15f to 36f926b Compare November 2, 2022 12:11
@ymao1 ymao1 force-pushed the flaky-test-index-thresh-avg-all branch from 36f926b to a507f1d Compare November 2, 2022 14:06
@ymao1 ymao1 changed the title Unskipping test Fixes Failing test: X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/spaces_only/tests/alerting/builtin_alert_types/index_threshold/alert·ts - alerting api integration spaces only Alerting builtin alertTypes index_threshold rule runs correctly: avg all Nov 3, 2022
@ymao1 ymao1 self-assigned this Nov 5, 2022
@ymao1 ymao1 added v8.6.0 Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Nov 5, 2022
@ymao1 ymao1 marked this pull request as ready for review November 5, 2022 12:25
@ymao1 ymao1 requested a review from a team as a code owner November 5, 2022 12:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ymao1
Copy link
Contributor Author

ymao1 commented Nov 7, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 58 64 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 66 72 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

Copy link
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1 ymao1 merged commit decfde6 into elastic:main Nov 7, 2022
@ymao1 ymao1 deleted the flaky-test-index-thresh-avg-all branch November 7, 2022 13:59
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.0
Projects
None yet
5 participants