Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Analyzer] Fix graph overlay persist despite filter group changes #144291

Merged
merged 6 commits into from
Nov 7, 2022

Conversation

christineweng
Copy link
Contributor

@christineweng christineweng commented Oct 31, 2022

This PR contain fixes for issue:

Summary

The analyzer (graph overlay) was shown despite the filter (open, acknowledged, or closed) changes. filterStatus is now passed to the useTimelineEvents to monitor change in filter.

Note that code is modified at the t-grid level (deeper) instead of the alerts table (i.e. onFilterChange). For instance, when switching from open to acknowledged, data fetching takes some time and the previous events table is still showing with loading animation. Disabling graph overlay before the new data is fully loaded causes a quick flash, hence the check is done in t-grid and disabling graph overlay only after the new data is fetched. This enables a better user experience.

This bug affects 2 pages, and both are now fixed:

Alerts in Alerts page

Screen.Recording.2022-10-31.at.5.43.27.PM.mov

Alerts in Rule Detail page

Screen.Recording.2022-10-31.at.5.44.34.PM.mov

@christineweng christineweng added release_note:skip Skip the PR/issue when compiling release notes Feature:Resolver Security Solution Resolver feature Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team v8.6.0 labels Oct 31, 2022
@christineweng christineweng self-assigned this Oct 31, 2022
@christineweng christineweng marked this pull request as ready for review November 1, 2022 14:49
@christineweng christineweng requested a review from a team as a code owner November 1, 2022 14:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Feature:Resolver)

@christineweng christineweng added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Nov 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@christineweng christineweng enabled auto-merge (squash) November 2, 2022 21:40
@YulNaumenko YulNaumenko self-requested a review November 7, 2022 15:56
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #1 / Alerts timeline Privileges: read only "before each" hook for "should not allow user with read only privileges to attach alerts to existing cases"
  • [job] [logs] Security Solution Tests #1 / Cases Creates a new case with timeline and opens the timeline
  • [job] [logs] Security Solution Tests #4 / url state sets and reads the url state for timeline by id

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
timelines 348 349 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
timelines 74.0KB 74.2KB +224.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
timelines 32 33 +1
Unknown metric groups

API count

id before after diff
timelines 457 458 +1

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 58 64 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 66 72 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @christineweng

@christineweng christineweng merged commit 494aa9c into elastic:main Nov 7, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 7, 2022
@michaelolo24 michaelolo24 added release_note:fix bug Fixes for quality problems that affect the customer experience and removed release_note:skip Skip the PR/issue when compiling release notes labels Nov 15, 2022
@michaelolo24 michaelolo24 removed the bug Fixes for quality problems that affect the customer experience label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Resolver Security Solution Resolver feature release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants