You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The analyzer (graph overlay) was shown despite the filter (open, acknowledged, or closed) changes. filterStatus is now passed to the useTimelineEvents to monitor change in filter.
Note that code is modified at the t-grid level (deeper) instead of the alerts table (i.e. onFilterChange). For instance, when switching from open to acknowledged, data fetching takes some time and the previous events table is still showing with loading animation. Disabling graph overlay before the new data is fully loaded causes a quick flash, hence the check is done in t-grid and disabling graph overlay only after the new data is fetched. This enables a better user experience.
[job][logs] Security Solution Tests #1 / Alerts timeline Privileges: read only "before each" hook for "should not allow user with read only privileges to attach alerts to existing cases"
[job][logs] Security Solution Tests #1 / Cases Creates a new case with timeline and opens the timeline
[job][logs] Security Solution Tests #4 / url state sets and reads the url state for timeline by id
Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.
Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contain fixes for issue:
Summary
The analyzer (graph overlay) was shown despite the filter (open, acknowledged, or closed) changes.
filterStatus
is now passed to theuseTimelineEvents
to monitor change in filter.Note that code is modified at the t-grid level (deeper) instead of the alerts table (i.e. onFilterChange). For instance, when switching from
open
toacknowledged
, data fetching takes some time and the previous events table is still showing with loading animation. Disabling graph overlay before the new data is fully loaded causes a quick flash, hence the check is done in t-grid and disabling graph overlay only after the new data is fetched. This enables a better user experience.This bug affects 2 pages, and both are now fixed:
Alerts in Alerts page
Screen.Recording.2022-10-31.at.5.43.27.PM.mov
Alerts in Rule Detail page
Screen.Recording.2022-10-31.at.5.44.34.PM.mov