Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Files] Copy updates and file picker single select #144398

Merged
merged 13 commits into from
Nov 3, 2022

Conversation

jloleysens
Copy link
Contributor

Summary

Checklist

Delete any items that are not applicable to this PR.

@jloleysens jloleysens added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Team:AppServicesUx Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) feature:Files v8.6.0 labels Nov 2, 2022
@jloleysens jloleysens requested a review from Dosant November 2, 2022 10:36
@jloleysens jloleysens requested a review from a team as a code owner November 2, 2022 10:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #23 / dashboard drilldowns Dashboard to dashboard drilldown Create & use drilldowns test dashboard to dashboard drilldown browser back/forward navigation works after drilldown navigation

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
files 26.5KB 26.8KB +214.0B
Unknown metric groups

API count

id before after diff
files 275 276 +1

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 57 63 +6
osquery 103 108 +5
securitySolution 439 445 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 65 71 +6
osquery 104 110 +6
securitySolution 516 522 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested single mode. works well 👍
thanks

@jloleysens jloleysens merged commit 4a44fd3 into elastic:main Nov 3, 2022
@jloleysens jloleysens deleted the files-update-filepicker-copy branch November 3, 2022 09:11
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting feature:Files release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants