Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing a flaky functional test ( chained input control) #144770

Merged
merged 5 commits into from
Nov 9, 2022
Merged

testing a flaky functional test ( chained input control) #144770

merged 5 commits into from
Nov 9, 2022

Conversation

rashmivkulkarni
Copy link
Contributor

trying to fix: #96997

@rashmivkulkarni rashmivkulkarni added Feature:Input Control Input controls visualization test_ui_functional release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.5.1 labels Nov 8, 2022
@rashmivkulkarni rashmivkulkarni self-assigned this Nov 8, 2022
@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1529 ( flaky test runner *200)

@rashmivkulkarni
Copy link
Contributor Author

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1533 ( *200)

@rashmivkulkarni rashmivkulkarni marked this pull request as ready for review November 9, 2022 05:56
@rashmivkulkarni rashmivkulkarni requested a review from a team as a code owner November 9, 2022 05:56
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #1 / Upgrade Assistant Deprecation pages "before all" hook for "renders the Elasticsearch deprecations page"

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rashmivkulkarni

nreese
nreese approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted offline with @rashmivkulkarni about these changes
LGTM, code review

@rashmivkulkarni rashmivkulkarni merged commit 49986da into elastic:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

Assignees

@rashmivkulkarni rashmivkulkarni

Labels
backport:skip This commit does not require backporting Feature:Input Control Input controls visualization release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v8.5.1 v8.6.0
Projects
None yet
Milestone
No milestone
4 participants
@rashmivkulkarni @kibana-ci @nreese @kibanamachine