[Security Solution][Bug fix] alerts table over 10k results #145441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christineweng
added
bug
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
YulNaumenko
reviewed
Nov 16, 2022
| @@ -140,7 +140,7 @@ const EmptyHeaderCellRender: ComponentType = () => null; | |||
|
|
|||
| const gridStyle: EuiDataGridStyle = { border: 'none', fontSize: 's', header: 'underline' }; | |||
|
|
|||
| const EuiDataGridContainer = styled.div<{ hideLastPage: boolean }>` | |||
| const EuiEventTableContainer = styled.div<{ hideLastPage: boolean }>` | |||
| ul.euiPagination__list { | |||
| li.euiPagination__item:last-child { | |||
| ${({ hideLastPage }) => `${hideLastPage ? 'display:none' : ''}`}; | |||
There was a problem hiding this comment.
Interesting, why we should hide this, but seems to be the reason.
YulNaumenko
approved these changes
Nov 16, 2022
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 16, 2022
…45441) This PR aims to address: - elastic#142965 ### Background On Alerts page -> Events table -> Event Rendered view, when there are over 10,000 alerts, upon clicking the last page, a warning message appears. <img width="800" alt="image" src="https://user-images.githubusercontent.com/18648970/202265598-5d9d657c-4918-408e-9f92-bcaafc904757.png"> The pop up is expected behavior according to documentation from: https://www.elastic.co/guide/en/elasticsearch/reference/current/paginate-search-results.html . > By default, you cannot use from and size to page through more than 10,000 hits. This limit is a safeguard set by the [index.max_result_window](https://www.elastic.co/guide/en/elasticsearch/reference/current/index-modules.html#index-max-result-window) index setting. ### After Currently the Grid view has a safeguard in place, where if there are more than 10k results, it will not show the last page, hence preventing user from clicking it and seeing the error pop up. - This PR applies the same approach by wrapping the `EventRenderView` component with the `EuiDataGridContainer`. - This PR also renamed `EuiDataGridContainer` to `EuiEventTableContainer` to indicate broader use. When there are over 10k records, last page is not available in pagination, and it is the same in Event Rendered View as in Grid view: https://user-images.githubusercontent.com/18648970/202271379-309cbb3c-5da6-4c46-9814-beeca39d1f36.mov (cherry picked from commit 3c77ec0)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 16, 2022
…45441) This PR aims to address: - elastic#142965 ### Background On Alerts page -> Events table -> Event Rendered view, when there are over 10,000 alerts, upon clicking the last page, a warning message appears. <img width="800" alt="image" src="https://user-images.githubusercontent.com/18648970/202265598-5d9d657c-4918-408e-9f92-bcaafc904757.png"> The pop up is expected behavior according to documentation from: https://www.elastic.co/guide/en/elasticsearch/reference/current/paginate-search-results.html . > By default, you cannot use from and size to page through more than 10,000 hits. This limit is a safeguard set by the [index.max_result_window](https://www.elastic.co/guide/en/elasticsearch/reference/current/index-modules.html#index-max-result-window) index setting. ### After Currently the Grid view has a safeguard in place, where if there are more than 10k results, it will not show the last page, hence preventing user from clicking it and seeing the error pop up. - This PR applies the same approach by wrapping the `EventRenderView` component with the `EuiDataGridContainer`. - This PR also renamed `EuiDataGridContainer` to `EuiEventTableContainer` to indicate broader use. When there are over 10k records, last page is not available in pagination, and it is the same in Event Rendered View as in Grid view: https://user-images.githubusercontent.com/18648970/202271379-309cbb3c-5da6-4c46-9814-beeca39d1f36.mov (cherry picked from commit 3c77ec0)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 17, 2022
…5441) (#145482) # Backport This will backport the following commits from `main` to `8.6`: - [[Security Solution][Bug fix] alerts table over 10k results (#145441)](#145441) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-11-16T23:38:43Z","message":"[Security Solution][Bug fix] alerts table over 10k results (#145441)\n\nThis PR aims to address:\r\n- https://github.com/elastic/kibana/issues/142965\r\n\r\n### Background\r\nOn Alerts page -> Events table -> Event Rendered view, when there are\r\nover 10,000 alerts, upon clicking the last page, a warning message\r\nappears.\r\n\r\n<img width=\"800\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/18648970/202265598-5d9d657c-4918-408e-9f92-bcaafc904757.png\">\r\n\r\nThe pop up is expected behavior according to documentation from:\r\nhttps://www.elastic.co/guide/en/elasticsearch/reference/current/paginate-search-results.html\r\n.\r\n\r\n> By default, you cannot use from and size to page through more than\r\n10,000 hits. This limit is a safeguard set by the\r\n[index.max_result_window](https://www.elastic.co/guide/en/elasticsearch/reference/current/index-modules.html#index-max-result-window)\r\nindex setting.\r\n\r\n\r\n### After\r\nCurrently the Grid view has a safeguard in place, where if there are\r\nmore than 10k results, it will not show the last page, hence preventing\r\nuser from clicking it and seeing the error pop up.\r\n- This PR applies the same approach by wrapping the `EventRenderView`\r\ncomponent with the `EuiDataGridContainer`.\r\n- This PR also renamed `EuiDataGridContainer` to\r\n`EuiEventTableContainer` to indicate broader use.\r\n\r\nWhen there are over 10k records, last page is not available in\r\npagination, and it is the same in Event Rendered View as in Grid view:\r\n\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/18648970/202271379-309cbb3c-5da6-4c46-9814-beeca39d1f36.mov","sha":"3c77ec063387ee1c7545774d069f134d55eabe2b","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v6.8.6","Team:Threat Hunting","Team: SecuritySolution","Team:Threat Hunting:Investigations","v8.7.0"],"number":145441,"url":"https://github.com/elastic/kibana/pull/145441","mergeCommit":{"message":"[Security Solution][Bug fix] alerts table over 10k results (#145441)\n\nThis PR aims to address:\r\n- https://github.com/elastic/kibana/issues/142965\r\n\r\n### Background\r\nOn Alerts page -> Events table -> Event Rendered view, when there are\r\nover 10,000 alerts, upon clicking the last page, a warning message\r\nappears.\r\n\r\n<img width=\"800\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/18648970/202265598-5d9d657c-4918-408e-9f92-bcaafc904757.png\">\r\n\r\nThe pop up is expected behavior according to documentation from:\r\nhttps://www.elastic.co/guide/en/elasticsearch/reference/current/paginate-search-results.html\r\n.\r\n\r\n> By default, you cannot use from and size to page through more than\r\n10,000 hits. This limit is a safeguard set by the\r\n[index.max_result_window](https://www.elastic.co/guide/en/elasticsearch/reference/current/index-modules.html#index-max-result-window)\r\nindex setting.\r\n\r\n\r\n### After\r\nCurrently the Grid view has a safeguard in place, where if there are\r\nmore than 10k results, it will not show the last page, hence preventing\r\nuser from clicking it and seeing the error pop up.\r\n- This PR applies the same approach by wrapping the `EventRenderView`\r\ncomponent with the `EuiDataGridContainer`.\r\n- This PR also renamed `EuiDataGridContainer` to\r\n`EuiEventTableContainer` to indicate broader use.\r\n\r\nWhen there are over 10k records, last page is not available in\r\npagination, and it is the same in Event Rendered View as in Grid view:\r\n\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/18648970/202271379-309cbb3c-5da6-4c46-9814-beeca39d1f36.mov","sha":"3c77ec063387ee1c7545774d069f134d55eabe2b"}},"sourceBranch":"main","suggestedTargetBranches":["6.8"],"targetPullRequestStates":[{"branch":"6.8","label":"v6.8.6","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145441","number":145441,"mergeCommit":{"message":"[Security Solution][Bug fix] alerts table over 10k results (#145441)\n\nThis PR aims to address:\r\n- https://github.com/elastic/kibana/issues/142965\r\n\r\n### Background\r\nOn Alerts page -> Events table -> Event Rendered view, when there are\r\nover 10,000 alerts, upon clicking the last page, a warning message\r\nappears.\r\n\r\n<img width=\"800\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/18648970/202265598-5d9d657c-4918-408e-9f92-bcaafc904757.png\">\r\n\r\nThe pop up is expected behavior according to documentation from:\r\nhttps://www.elastic.co/guide/en/elasticsearch/reference/current/paginate-search-results.html\r\n.\r\n\r\n> By default, you cannot use from and size to page through more than\r\n10,000 hits. This limit is a safeguard set by the\r\n[index.max_result_window](https://www.elastic.co/guide/en/elasticsearch/reference/current/index-modules.html#index-max-result-window)\r\nindex setting.\r\n\r\n\r\n### After\r\nCurrently the Grid view has a safeguard in place, where if there are\r\nmore than 10k results, it will not show the last page, hence preventing\r\nuser from clicking it and seeing the error pop up.\r\n- This PR applies the same approach by wrapping the `EventRenderView`\r\ncomponent with the `EuiDataGridContainer`.\r\n- This PR also renamed `EuiDataGridContainer` to\r\n`EuiEventTableContainer` to indicate broader use.\r\n\r\nWhen there are over 10k records, last page is not available in\r\npagination, and it is the same in Event Rendered View as in Grid view:\r\n\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/18648970/202271379-309cbb3c-5da6-4c46-9814-beeca39d1f36.mov","sha":"3c77ec063387ee1c7545774d069f134d55eabe2b"}}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
![https://user-images.githubusercontent.com/18648970/202265598-5d9d657c-4918-408e-9f92-bcaafc904757.png\">\r\n\r\nThe](https://user-images.githubusercontent.com/18648970/202265598-5d9d657c-4918-408e-9f92-bcaafc904757.png\">\r\n\r\nThe){kind=link}
kibanamachine
added a commit
that referenced
this pull request
Nov 17, 2022
…5441) (#145481) # Backport This will backport the following commits from `main` to `8.5`: - [[Security Solution][Bug fix] alerts table over 10k results (#145441)](#145441) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-11-16T23:38:43Z","message":"[Security Solution][Bug fix] alerts table over 10k results (#145441)\n\nThis PR aims to address:\r\n- https://github.com/elastic/kibana/issues/142965\r\n\r\n### Background\r\nOn Alerts page -> Events table -> Event Rendered view, when there are\r\nover 10,000 alerts, upon clicking the last page, a warning message\r\nappears.\r\n\r\n<img width=\"800\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/18648970/202265598-5d9d657c-4918-408e-9f92-bcaafc904757.png\">\r\n\r\nThe pop up is expected behavior according to documentation from:\r\nhttps://www.elastic.co/guide/en/elasticsearch/reference/current/paginate-search-results.html\r\n.\r\n\r\n> By default, you cannot use from and size to page through more than\r\n10,000 hits. This limit is a safeguard set by the\r\n[index.max_result_window](https://www.elastic.co/guide/en/elasticsearch/reference/current/index-modules.html#index-max-result-window)\r\nindex setting.\r\n\r\n\r\n### After\r\nCurrently the Grid view has a safeguard in place, where if there are\r\nmore than 10k results, it will not show the last page, hence preventing\r\nuser from clicking it and seeing the error pop up.\r\n- This PR applies the same approach by wrapping the `EventRenderView`\r\ncomponent with the `EuiDataGridContainer`.\r\n- This PR also renamed `EuiDataGridContainer` to\r\n`EuiEventTableContainer` to indicate broader use.\r\n\r\nWhen there are over 10k records, last page is not available in\r\npagination, and it is the same in Event Rendered View as in Grid view:\r\n\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/18648970/202271379-309cbb3c-5da6-4c46-9814-beeca39d1f36.mov","sha":"3c77ec063387ee1c7545774d069f134d55eabe2b","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v6.8.6","Team:Threat Hunting","Team: SecuritySolution","Team:Threat Hunting:Investigations","v8.7.0"],"number":145441,"url":"https://github.com/elastic/kibana/pull/145441","mergeCommit":{"message":"[Security Solution][Bug fix] alerts table over 10k results (#145441)\n\nThis PR aims to address:\r\n- https://github.com/elastic/kibana/issues/142965\r\n\r\n### Background\r\nOn Alerts page -> Events table -> Event Rendered view, when there are\r\nover 10,000 alerts, upon clicking the last page, a warning message\r\nappears.\r\n\r\n<img width=\"800\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/18648970/202265598-5d9d657c-4918-408e-9f92-bcaafc904757.png\">\r\n\r\nThe pop up is expected behavior according to documentation from:\r\nhttps://www.elastic.co/guide/en/elasticsearch/reference/current/paginate-search-results.html\r\n.\r\n\r\n> By default, you cannot use from and size to page through more than\r\n10,000 hits. This limit is a safeguard set by the\r\n[index.max_result_window](https://www.elastic.co/guide/en/elasticsearch/reference/current/index-modules.html#index-max-result-window)\r\nindex setting.\r\n\r\n\r\n### After\r\nCurrently the Grid view has a safeguard in place, where if there are\r\nmore than 10k results, it will not show the last page, hence preventing\r\nuser from clicking it and seeing the error pop up.\r\n- This PR applies the same approach by wrapping the `EventRenderView`\r\ncomponent with the `EuiDataGridContainer`.\r\n- This PR also renamed `EuiDataGridContainer` to\r\n`EuiEventTableContainer` to indicate broader use.\r\n\r\nWhen there are over 10k records, last page is not available in\r\npagination, and it is the same in Event Rendered View as in Grid view:\r\n\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/18648970/202271379-309cbb3c-5da6-4c46-9814-beeca39d1f36.mov","sha":"3c77ec063387ee1c7545774d069f134d55eabe2b"}},"sourceBranch":"main","suggestedTargetBranches":["6.8"],"targetPullRequestStates":[{"branch":"6.8","label":"v6.8.6","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145441","number":145441,"mergeCommit":{"message":"[Security Solution][Bug fix] alerts table over 10k results (#145441)\n\nThis PR aims to address:\r\n- https://github.com/elastic/kibana/issues/142965\r\n\r\n### Background\r\nOn Alerts page -> Events table -> Event Rendered view, when there are\r\nover 10,000 alerts, upon clicking the last page, a warning message\r\nappears.\r\n\r\n<img width=\"800\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/18648970/202265598-5d9d657c-4918-408e-9f92-bcaafc904757.png\">\r\n\r\nThe pop up is expected behavior according to documentation from:\r\nhttps://www.elastic.co/guide/en/elasticsearch/reference/current/paginate-search-results.html\r\n.\r\n\r\n> By default, you cannot use from and size to page through more than\r\n10,000 hits. This limit is a safeguard set by the\r\n[index.max_result_window](https://www.elastic.co/guide/en/elasticsearch/reference/current/index-modules.html#index-max-result-window)\r\nindex setting.\r\n\r\n\r\n### After\r\nCurrently the Grid view has a safeguard in place, where if there are\r\nmore than 10k results, it will not show the last page, hence preventing\r\nuser from clicking it and seeing the error pop up.\r\n- This PR applies the same approach by wrapping the `EventRenderView`\r\ncomponent with the `EuiDataGridContainer`.\r\n- This PR also renamed `EuiDataGridContainer` to\r\n`EuiEventTableContainer` to indicate broader use.\r\n\r\nWhen there are over 10k records, last page is not available in\r\npagination, and it is the same in Event Rendered View as in Grid view:\r\n\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/18648970/202271379-309cbb3c-5da6-4c46-9814-beeca39d1f36.mov","sha":"3c77ec063387ee1c7545774d069f134d55eabe2b"}}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address:
Background
On Alerts page -> Events table -> Event Rendered view, when there are over 10,000 alerts, upon clicking the last page, a warning message appears.
The pop up is expected behavior according to documentation from: https://www.elastic.co/guide/en/elasticsearch/reference/current/paginate-search-results.html .
After
Currently the Grid view has a safeguard in place, where if there are more than 10k results, it will not show the last page, hence preventing user from clicking it and seeing the error pop up.
EventRenderViewcomponent with theEuiDataGridContainer.EuiDataGridContainertoEuiEventTableContainerto indicate broader use.When there are over 10k records, last page is not available in pagination, and it is the same in Event Rendered View as in Grid view:
Screen.Recording.2022-11-16.at.1.09.47.PM.mov