Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Fix hard-coded link in create rule API #145483

Merged
merged 1 commit into from
Nov 17, 2022
Merged

[DOCS] Fix hard-coded link in create rule API #145483

merged 1 commit into from
Nov 17, 2022

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 16, 2022

Summary

Relates to elastic/docs#2518

This PR replaces a hard-coded link that includes master, which would case this type of failure when we switch to main:

16:25:18 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/kibana/7.17/create-rule-api.html contains broken links to:
16:25:18 INFO:build_docs: - en/kibana/master/sharing-saved-objects.html

@lcawl lcawl added docs v7.17.8 Team:Docs release_note:skip Skip the PR/issue when compiling release notes v7.13.5 v7.14.3 v7.15.3 v7.16.4 auto-backport Deprecated - use backport:version if exact versions are needed labels Nov 16, 2022
@lcawl lcawl marked this pull request as ready for review November 17, 2022 00:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@lcawl lcawl merged commit cae15d2 into elastic:7.17 Nov 17, 2022
@lcawl lcawl deleted the create-rule-link branch November 17, 2022 00:09
lcawl added a commit to lcawl/kibana that referenced this pull request Nov 17, 2022
@lcawl
[DOCS] Fix hard-coded link in create rule API (elastic#145483)
f0def1c
lcawl added a commit to lcawl/kibana that referenced this pull request Nov 17, 2022
@lcawl
[DOCS] Fix hard-coded link in create rule API (elastic#145483)
0d36ab2
lcawl added a commit to lcawl/kibana that referenced this pull request Nov 17, 2022
@lcawl
[DOCS] Fix hard-coded link in create rule API (elastic#145483)
7bc48de
lcawl added a commit to lcawl/kibana that referenced this pull request Nov 17, 2022
@lcawl
[DOCS] Fix hard-coded link in create rule API (elastic#145483)
cfdf2e6
This was referenced Nov 17, 2022
Merged
Merged
Merged
Merged
lcawl added a commit that referenced this pull request Nov 17, 2022
@lcawl
[7.16][DOCS] Fix hard-coded link in create rule API (#145483) (#145484)
528482f
lcawl added a commit that referenced this pull request Nov 17, 2022
@lcawl
[7.15][DOCS] Fix hard-coded link in create rule API (#145483) (#145485)
44324d5
@lcawl lcawl mentioned this pull request Nov 17, 2022
Open
20 tasks
lcawl added a commit that referenced this pull request Nov 17, 2022
@lcawl
[7.13][DOCS] Fix hard-coded link in create rule API (#145483) (#145487)
3fe880a
lcawl added a commit that referenced this pull request Nov 17, 2022
@lcawl
[7.14][DOCS] Fix hard-coded link in create rule API (#145483) (#145486)
63cc636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.13.5 v7.14.3 v7.15.3 v7.16.4 v7.17.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcawl @elasticmachine