-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quick check of current URL to skip timepicker #146462
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
3702547
quick check of current URL to skip timepicker
3a05844
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine 84a0bf6
changed setAbsoluteTime to a wrapper that checks URL
1b69342
resolve merge
989a21d
Merge branch 'main' of github.com:elastic/kibana into timepickerCheck…
f90053c
Merge branch 'main' into timepickerChecksUrl
17ca23e
Merge branch 'main' into timepickerChecksUrl
d3a2a7c
Merge branch 'main' into timepickerChecksUrl
bb010e5
add force=false default param to setAbsoluteTime
d7dbdde
Merge branch 'timepickerChecksUrl' of github.com:LeeDr/kibana into ti…
15a1d92
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine d535634
fix conditional branch, decoodeURL
7465da6
fix conditional branch, decoodeURL
37c2990
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine cb1b50f
Merge branch 'main' into timepickerChecksUrl
c3375fc
Merge branch 'main' into timepickerChecksUrl
bee5c67
Merge branch 'main' into timepickerChecksUrl
dmlemeshko 4f4e096
Merge branch 'main' into timepickerChecksUrl
dmlemeshko a681d41
revert changes in area chart tests
dmlemeshko 61056f4
Merge branch 'main' into timepickerChecksUrl
dmlemeshko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under what circumstances does it make sense to force?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off the top of my head, anytime flakiness is encountered (timepicker can be notorious sometimes).
This pr is a pr from a former elastic employee (our boss) and we did discuss at some length.
Further, there is some use of force flag within this pr.
@dmlemeshko may have more to weigh in on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewctate , it is a good question. For some reason Lee picked area chart, maybe he was doing some testing.
You might know more about this test, and if there is no good reason re-resetting the time picker with already the same range, I can push an update and remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmlemeshko I agree with Andrew, this test was not flaky. I might miss something here but I would propose to remove it!