-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Lens] New trigger actions for chart legends and table cell actions #146779
Merged
Merged
Changes from 29 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
4d41a54
register security lens cellValue actions
semd be16993
add cell actions to visualizations
semd 5877254
add to timeline display name
semd 11bc30e
rollback dashboards table test
semd 37475e5
lens embeddable conflict solved
semd 8f1e3be
fix types
semd 0fee044
rollback LensRendererEvent type
semd 39bed22
fix tests
semd 6440f4f
unify security datagrid cellActions
semd 34ebdf9
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine 0b9ba1a
security actions popover syles
semd 9eab7ca
Merge branch '145708_viz_data_value_actions' of https://github.com/se…
semd 28efa11
new tests added
semd 91c14b8
Merge branch 'main' into 145708_viz_data_value_actions
kibanamachine 2ca99c2
Merge branch 'main' into 145708_viz_data_value_actions
kibanamachine 4c5d024
Merge branch 'main' into 145708_viz_data_value_actions
angorayc 48ab3a9
Merge branch 'main' into 145708_viz_data_value_actions
angorayc 020541f
Merge branch 'main' into 145708_viz_data_value_actions
angorayc 80d36cc
remove comment
semd 15334b2
Merge remote-tracking branch 'upstream/main' into 145708_viz_data_val…
semd 41cca66
Merge branch '145708_viz_data_value_actions' of https://github.com/se…
semd f60c338
added interative conditionals + tests
semd dcff83d
tests
semd d2ba3d9
Merge remote-tracking branch 'upstream/main' into 145708_viz_data_val…
semd f481439
fix path change
semd 585263c
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 83aa17c
encapsulate layerCellValueActions fuction
semd f5ef5f6
Merge branch '145708_viz_data_value_actions' of https://github.com/se…
semd 7843c3f
Merge remote-tracking branch 'upstream/main' into 145708_viz_data_val…
semd cd1bdbe
combine async calls
semd 8432fb8
Merge remote-tracking branch 'upstream/main' into 145708_viz_data_val…
semd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
...ions/expression_partition_vis/public/expression_renderers/partition_vis_renderer.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
import { createMockPieParams, createMockVisData } from '../mocks'; | ||
import { CellValueAction } from '../types'; | ||
import { getColumnCellValueActions } from './partition_vis_renderer'; | ||
|
||
const visParams = createMockPieParams(); | ||
const visData = createMockVisData(); | ||
|
||
const cellValueAction: CellValueAction = { | ||
displayName: 'Test', | ||
id: 'test', | ||
iconType: 'test-icon', | ||
execute: () => {}, | ||
}; | ||
|
||
describe('getColumnCellValueActions', () => { | ||
it('should get column cellValue actions for each params bucket', async () => { | ||
const result = await getColumnCellValueActions(visParams, visData, async () => [ | ||
cellValueAction, | ||
]); | ||
expect(result).toHaveLength(visParams.dimensions.buckets?.length ?? 0); | ||
}); | ||
|
||
it('should contain the cellValue actions', async () => { | ||
const result = await getColumnCellValueActions(visParams, visData, async () => [ | ||
cellValueAction, | ||
cellValueAction, | ||
]); | ||
expect(result[0]).toEqual([cellValueAction, cellValueAction]); | ||
}); | ||
|
||
it('should return empty array if no buckets', async () => { | ||
const result = await getColumnCellValueActions( | ||
{ ...visParams, dimensions: { ...visParams.dimensions, buckets: undefined } }, | ||
visData, | ||
async () => [cellValueAction] | ||
); | ||
expect(result).toEqual([]); | ||
}); | ||
|
||
it('should return empty array if getCompatibleCellValueActions not passed', async () => { | ||
const result = await getColumnCellValueActions(visParams, visData, undefined); | ||
expect(result).toEqual([]); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we combine this with the palette async code below?