Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution] Render histograms with Lens #147261

Merged
merged 108 commits into from
Feb 2, 2023

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Dec 8, 2022

Summary

Relevant issue: #136409

These are all behind feature flag chartEmbeddablesEnabled


Changes:

  1. Legends are all moved to the left side of the chart to avoid overlapping with chart actions.
  2. The second group by of Alerts Trend Chart is removed (as it is always disabled).

Events:

Screenshot 2023-01-25 at 15 33 27


Top N

Screenshot 2023-01-25 at 15 34 21


No indices:

Screenshot 2022-12-21 at 17 03 05


Alerts - Trend

Screenshot 2023-01-25 at 15 34 52


Alerts - Treemap (Not included in this PR - #149592)

Big Difference after converting to Lens. Likely to have a redesign:

Known issues:

  1. Alerts tree map: Is not rendered exactly the same due to the limits of dimension of Lens.
  2. No value display in each legend item for alerts tree map
  3. Background color cannot be decided by risk score

Before:
Screenshot 2023-01-10 at 12 00 51

After:
Screenshot 2023-01-25 at 15 35 16


Alerts - Charts (Not included in this PR - #149592)

Lens does not support the design. Likely to have a redesign:

Screenshot 2023-01-25 at 15 35 55


Alerts - Table

Screenshot 2022-12-21 at 17 12 25

Known issues:

  1. Reset group by field is missing when no data to display #149828 - 8.7
  2. Unable to restore a column after hiding it. - 8.8
  3. Open in timeline and copy to clip board cellActions have the wrong query in Lens Embeddable #150048 - 8.7
  4. Lens does not support nested fields, we have to exclude them from the dropdown #150158 - 8.7

Alerts - Preview

Known issue:
There's no legend in alerts preview as its legend action, filter in, filter out are not useful on rule creation page. - #149220

Screenshot 2023-01-26 at 13 32 00

Checklist

@angorayc angorayc changed the title render histogram with lens [SecuritySolution] Render histograms with Lens Dec 8, 2022
@angorayc angorayc enabled auto-merge (squash) February 2, 2023 13:22
@angorayc angorayc merged commit 9cfec58 into elastic:main Feb 2, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3579 3584 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.9MB 12.9MB +23.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants