-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SecuritySolution] Render histograms with Lens #147261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 tasks
…-ref HEAD~1..HEAD --fix'
… histogram-with-lens
…-ref HEAD~1..HEAD --fix'
machadoum
reviewed
Feb 1, 2023
...public/common/components/visualization_actions/lens_attributes/common/alerts/alerts_table.ts
Show resolved
Hide resolved
… histogram-with-lens
machadoum
approved these changes
Feb 2, 2023
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:Threat Hunting:Explore
Team:Threat Hunting
Security Solution Threat Hunting Team
v8.7.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relevant issue: #136409
These are all behind feature flag
chartEmbeddablesEnabled
Changes:
group by
of Alerts Trend Chart is removed (as it is always disabled).Events:
Top N
No indices:
Alerts - Trend
Alerts - Treemap(Not included in this PR - #149592)Big Difference after converting to Lens. Likely to have a redesign:
Known issues:
Before:
![Screenshot 2023-01-10 at 12 00 51](https://user-images.githubusercontent.com/6295984/211546444-f98b0f4a-0666-493c-b57e-934b3d154211.png)
After:
![Screenshot 2023-01-25 at 15 35 16](https://user-images.githubusercontent.com/6295984/214606117-7a1e78a4-8947-4d95-9994-2acb106ca3af.png)
Alerts - Charts(Not included in this PR - #149592)Lens does not support the design. Likely to have a redesign:
Alerts - Table
Known issues:
Alerts - Preview
Known issue:
There's no legend in alerts preview as its legend action, filter in, filter out are not useful on rule creation page. - #149220
Checklist