[Failing Test] Fixes Spaces Data Before All Failure

[jeramysoucy]

Fixes #52714
Fixes #52715

After all failure likely due to before failure - when before fails, the data set is not installed and cannot be removed.

Before all failure seems likely to be a race condition of one or more elements being 'not interactable'. I was unable to reproduce the issue locally and via a Flaky Test Runner, but walking through the code noticed an incorrect attribute reference and a few places where we could improve determinism.

• Replaced 'showSampleDataAccordion'->'class' check with 'showSampleDataButton'->'aria-expanded'
• Added deterministic verification of sample data accordion open
• Mirrored previous timing/enable check fix to 'removeSampleDataSet' in 'addSampleDataSet'
• Improved determinism in 'removeSampleDataSet', adding an initial check for whether the data set was installed
• Added additional debug logs to improve any future troubleshooting

[elasticmachine]

Pinging @elastic/kibana-security (Team:Security)

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 0a63fc3

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id	before	after	diff
osquery	1	2	+1

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	19	21	+2
fleet	61	67	+6
osquery	109	115	+6
securitySolution	445	451	+6
total			+20

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	20	22	+2
fleet	70	76	+6
osquery	110	117	+7
securitySolution	521	527	+6
total			+21

History

• 💔 Build #94847 failed eed1d10
• 💛 Build #94695 was flaky 334aa7e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[thomheymann]

LGTM!