You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored Top nav actions code to be more modular
Created new Locator object for Lens
Enabled server side to make Short URL work with it
Added unit tests for it
Extended getEditPath to support filters and refreshInterval
Extended mounting code in Lens to handle a new type of incoming context
This produced a discrete amount of branching, due to inconsistency of the context type coming from different sources (Discover, Agg-based/TSVB, Lens itself...). Perhaps it's worth discussing having a refactoring of the context type here?
Add new Share action
Added new objectTypeTitle prop to have custom titles on Share popover
Replaced the Download CSV action and move it as menu item
Refactor code into share item provider + (lazy) panel content
Add debug flag to make CSV download testable
Add functional tests for CSV download
Add Permalink action
Integrate Permalink with Short URL service
Tweaked Permalink action to work with SO custom URL
Tweaked Permalink action to handle disabled state
Updated unit tests with new features
New share function test suite created
Extended browser service with a new method to have a blank tab in browser
New helper functions in Lens to test Share feature
Checklist
Delete any items that are not applicable to this PR.
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
Risk
Probability
Severity
Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.
Low
High
Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.
High
Low
Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.
Medium
High
Unit tests will verify that any feature flag or plugin combination still results in our service operational.
Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #75316
getEditPath
to supportfilters
andrefreshInterval
context
type coming from different sources (Discover, Agg-based/TSVB, Lens itself...). Perhaps it's worth discussing having a refactoring of the context type here?objectTypeTitle
prop to have custom titles on Share popoverDownload CSV
action and move it as menu itembrowser
service with a new method to have a blank tab in browserChecklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers