Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Honor index mode time_serie from the package #148292

Merged
merged 3 commits into from
Jan 4, 2023

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jan 3, 2023

Summary

Resolve #146804

Honor the index mode time_serie settings when defined in the package.

It's currently not possible to define that settings in a component template, it's why it's on the index template.

As discussed in #146804 index mode:time_serie also enable synthetic source mode by default

Before

Screen Shot 2023-01-04 at 9 01 53 AM

After

Screen Shot 2023-01-03 at 11 27 02 AM

Screen Shot 2023-01-03 at 12 02 28 PM

It also fix a bug where when the package was defining time series the UI was disabling synthetic source

How to tests

You can use the following package where the substatus metric is using time series
nginx-1.6.1.zip

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0 labels Jan 3, 2023
@nchaulet nchaulet self-assigned this Jan 3, 2023
@nchaulet nchaulet force-pushed the feature-time-series-index-mode branch 2 times, most recently from 3b29087 to a3e1a3f Compare January 3, 2023 15:22
@nchaulet nchaulet marked this pull request as ready for review January 3, 2023 16:15
@nchaulet nchaulet requested a review from a team as a code owner January 3, 2023 16:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet force-pushed the feature-time-series-index-mode branch from a3e1a3f to 2b500a9 Compare January 3, 2023 16:20
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 900.1KB 899.5KB -607.0B

History

  • 💔 Build #97846 failed a3e1a3f9fb9ddcff5f595212388421c6b95b1667
  • 💔 Build #97783 failed 3b290872cb7b9c3aef7f88cb41be62318e8e91d6
  • 💔 Build #97765 failed 7701c80fcaed17cca3237e24f7e77b27f8467e65

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nchaulet nchaulet merged commit c1681d2 into elastic:main Jan 4, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 4, 2023
@nchaulet nchaulet deleted the feature-time-series-index-mode branch January 4, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Honor index_mode: time_series setting during package installation
5 participants