-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Performance] Properly await deletion in journey #148768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran it locally and can see the event been sent
Report event "performance_metric" {
proc [functional-tests] │ ebt_event: {
proc [functional-tests] │ timestamp: '2023-01-13T17:27:56.968Z',
proc [functional-tests] │ event_type: 'performance_metric',
proc [functional-tests] │ context: {
proc [functional-tests] │ isDev: true,
proc [functional-tests] │ isDistributable: false,
proc [functional-tests] │ version: '8.7.0',
proc [functional-tests] │ branch: 'main',
proc [functional-tests] │ buildNum: 9007199254740991,
proc [functional-tests] │ buildSha: 'XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX',
proc [functional-tests] │ session_id: 'f16313a3-9058-42d9-a64e-58a40609d407',
proc [functional-tests] │ user_agent: 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36',
proc [functional-tests] │ preferred_language: 'en-GB',
proc [functional-tests] │ preferred_languages: [ 'en-GB' ],
proc [functional-tests] │ viewport_width: 1280,
proc [functional-tests] │ viewport_height: 720,
proc [functional-tests] │ cluster_name: 'elasticsearch',
proc [functional-tests] │ cluster_uuid: 'kd224oVlSTGEYYSBjp0ANg',
proc [functional-tests] │ cluster_version: '8.7.0-SNAPSHOT',
proc [functional-tests] │ pageName: 'application:dashboards:list',
proc [functional-tests] │ applicationId: 'dashboards',
proc [functional-tests] │ page: 'list',
proc [functional-tests] │ labels: {
proc [functional-tests] │ ciBuildNumber: 0,
proc [functional-tests] │ isPr: false,
proc [functional-tests] │ journeyName: 'dashboard_listing_page'
proc [functional-tests] │ },
proc [functional-tests] │ userId: '986051385feae5b9850804db2d701c0b029ad24f09bce340c12aee7a5c8a0391',
proc [functional-tests] │ isElasticCloudUser: false,
proc [functional-tests] │ license_id: 'd6c75e2d-eb2e-481f-8d3e-3f2b2d37748a',
proc [functional-tests] │ license_status: 'active',
proc [functional-tests] │ license_type: 'basic'
proc [functional-tests] │ },
proc [functional-tests] │ properties: {
proc [functional-tests] │ eventName: 'saved_object_delete_time',
proc [functional-tests] │ duration: 1189.699999988079,
proc [functional-tests] │ meta: { saved_object_type: 'dashboard', total: 1 }
proc [functional-tests] │ }
proc [functional-tests] │ }
proc [functional-tests] │ }
I can also see APM traces in place (harder to say if there any missing transactions), so I think we are good.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
## Summary Add a new dashboard. Blocked by #148768 ### Checklist Delete any items that are not applicable to this PR. - ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~~ - ~~[ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - ~~[ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))~~ - ~~[ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~~ - ~~[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - ~~[ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~~ - ~~[ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~~ ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
## Summary Add a new dashboard. Blocked by elastic#148768 ### Checklist Delete any items that are not applicable to this PR. - ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~~ - ~~[ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - ~~[ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))~~ - ~~[ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~~ - ~~[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - ~~[ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~~ - ~~[ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~~ ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Summary
Closes #148619
Checklist
Delete any items that are not applicable to this PR.
[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)[ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list[ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)[ ] This was checked for cross-browser compatibilityFor maintainers