Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Fix page crashes after editing the filter #149048

Merged
merged 7 commits into from
Jan 23, 2023
Merged

[SecuritySolution] Fix page crashes after editing the filter #149048

merged 7 commits into from
Jan 23, 2023

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Jan 17, 2023 •
edited
Loading

Summary

Fixes: #148710

Screenshot 2023-01-11 at 10 15 24

Steps to verify:

  1. Enable feature flags: Please add this to kibana.dev.yml xpack.securitySolution.enableExperimental: ['chartEmbeddablesEnabled']

  2. Go to alerts host details page.

  3. Click on the donut chart to apply the filter.

  4. Click the filter it applied to global search bar, and select Edit filter.

  5. Should edit the filter successfully.

@angorayc angorayc changed the title add getName [SecuritySolution] Fix page crashes after editing the filter Jan 17, 2023
@angorayc angorayc added bug Fixes for quality problems that affect the customer experience Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.7.0 backport:skip This commit does not require backporting labels Jan 17, 2023
@angorayc angorayc marked this pull request as ready for review January 19, 2023 09:15
@angorayc angorayc requested a review from a team as a code owner January 19, 2023 09:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@angorayc angorayc added the release_note:skip Skip the PR/issue when compiling release notes label Jan 19, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.8MB 12.8MB +120.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stephmilovic
stephmilovic approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

@angorayc angorayc merged commit 61820b4 into elastic:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SecuritySolution] Page crashes after editing the filter applied from a Lens Embeddable.
4 participants
@angorayc @elasticmachine @kibana-ci @stephmilovic