-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] KPI visualizations on Alerts Page #149173
[Security Solution] KPI visualizations on Alerts Page #149173
Conversation
…into 8.7_Summary_Charts
29b4b24
to
de009c2
Compare
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
remove draggable path fix ci uuid ref
a70a3a8
to
a856305
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explore changes LGTM, thanks!
@elasticmachine merge upstream |
@elasticmachine merge upstream |
...lution/public/detections/components/alerts_kpis/alerts_by_type_panel/alerts_by_type.test.tsx
Outdated
Show resolved
Hide resolved
...lution/public/detections/components/alerts_kpis/alerts_by_type_panel/alerts_by_type.test.tsx
Show resolved
Hide resolved
...n/public/detections/components/alerts_kpis/alerts_progress_bar_panel/alerts_progress_bar.tsx
Outdated
Show resolved
Hide resolved
...rity_solution/public/detections/components/alerts_kpis/alerts_progress_bar_panel/helpers.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Reviewed the code, pulled down and tested, and everything works well! Just add a couple translations and we should be good to go! Thanks!
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
## Summary This PR is a part 2 of elastic#146938 that populates the remaining 2 charts for the summary section on Alerts Page. Capabilities added - Alerts by type: alert count by rule and by type (prevention vs. detection) - Top alerts: top 10 alert grouping based on user selected drop down Changes from previous PR - Refactor `useSeverityChartData` to `useSummaryChartData` so that it can be used by all 3 charts to fetch data - Move `SeverityLevel` chart up one level to `alerts_kpi` folder to better isolate components for testing. Feature flag: `alertsPageChartsEnabled` ![image](https://user-images.githubusercontent.com/18648970/213945018-57a15c60-ed53-4e86-90f5-c1909e88420d.png) ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…150242) ## Summary This PR is part 3 of #149173 and #146938 that add additional KPI visualizations to the Alerts page. #### Capabilities added Charts menu: changed from a drop down selection to tabs format, with wording that better describe the usage of each charts Chart collapse: when the toggle is collapsed, instead of showing the same menu options, a summary of the KPIs are shown. Feature flag: `alertsPageChartsEnabled` is set to true by default #### Changes from previous PR Before this PR, each chart (trend, tree map etc.) keeps its own state of toggle status. This is no longer suitable because the new layout does not show options when collapsed. This PR also moves the toggle status to be at the chart panel's level, and be passed down to each chart component. One exception is the histogram (trend analysis), it is currently being used in alerts detail page and overview dashboard, hence it needs to keep track of toggle state on its own. #### When charts are expanded ![image](https://user-images.githubusercontent.com/18648970/216714087-a872cdeb-5d69-40fd-a392-4130ad6c925c.png) #### When collapsed and has data ![image](https://user-images.githubusercontent.com/18648970/216714168-e4d72ca2-b214-48d8-9182-932927c0b473.png) #### When collapsed with no data ![image](https://user-images.githubusercontent.com/18648970/216714250-628b96d2-6380-4999-a2a6-ed22eb0d8791.png) ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
Summary
This PR is a part 2 of #146938 that populates the remaining 2 charts for the summary section on Alerts Page.
Capabilities added
Changes from previous PR
useSeverityChartData
touseSummaryChartData
so that it can be used by all 3 charts to fetch dataSeverityLevel
chart up one level toalerts_kpi
folder to better isolate components for testing.Feature flag:
alertsPageChartsEnabled
Checklist
Delete any items that are not applicable to this PR.
For maintainers