fix locally broken unit tests #149811
fix locally broken unit tests #149811
Conversation
|
Pinging @elastic/apm-ui (Team:APM) |
achyutjhunjhunwala
added
the
release_note:skip
There was a problem hiding this comment.
LGTM, but:
It actually took me some time to figure out why a key property is needed here since there's no loop to create this annotation. But I see that this is needed because we wrapped the result of getAnnotations in []. Maybe you cold remove this [getAnnotations()] from here https://github.com/elastic/kibana/blob/main/x-pack/plugins/apm/public/components/shared/charts/timeseries_chart_with_context.tsx#L108, and return an array from the getAnnotations itself. You could also convert to a standard function instead of an arrow function, this will avoid the TimeseriesChart to render unnecessarily because of these two things.
|
@cauemarcondes Great catch on the performance improvement part. Updated the code |
|
@cauemarcondes Nice perf improvement 👍 |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.7.0
backport:skip
## Summary Due to an old Pull request, 2 of the Unit Tests started to fail locally. Somehow they won't fail on the CI which made them tough to identify initially. This PR fixes those broken unit tests.
Summary
Due to an old Pull request, 2 of the Unit Tests started to fail locally. Somehow they won't fail on the CI which made them tough to identify initially.
This PR fixes those broken unit tests.