-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kibana-plugin CLI][master] add optimize task and skip-optimize option on install task #14991
[kibana-plugin CLI][master] add optimize task and skip-optimize option on install task #14991
Conversation
Can one of the admins verify this patch? |
This is awesome and much needed, thanks for the PR @gwintzer. A couple discussion points, /cc @tylersmalley :
usage:
Thoughts? |
@jbudz, I agree with all of your points but changing the default to not optimize during plugin installation might be considered a breaking change. I would be for backporting this to 6.0, and in 7 flipping the defaults. Though, hopefully then we will have removed the optimize process altogether. |
Here's the backport to 6.1, I have ones for 6.0 and 5.6 if anyone else needs them https://gist.github.com/FireBurn/2ecaaff4c40a6dd9bb865f732a9754a7 |
Any idea when you're gonna merge this? |
I hope this feature will release soon.
|
+1 to getting this merged sometime soonish |
+1, this is a pain in the arse and results in long builds for us! |
+1 I do confirm the pain |
👍 , we be a great feature for us! Then we would be able to remove some nasty workaround hacks... |
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Closing since we've implemented this over in #16302 |
Same as #14515, but with my pull request against master
Here's a PR according to the issue #6057.
Add a new optimize task to the kibana-plugin CLI
Add an option --skip-optimize for the existing install task
Example :