Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kibana-plugin CLI][master] add optimize task and skip-optimize option on install task #14991

Conversation

gwintzer
Copy link

Same as #14515, but with my pull request against master

Here's a PR according to the issue #6057.

Add a new optimize task to the kibana-plugin CLI
Add an option --skip-optimize for the existing install task
Example :

#install your plugins faster
./bin/kibana-plugin install --skip-optimize plugin1
./bin/kibana-plugin install --skip-optimize plugin2

#finally run the optimize task once
./bin/kibana-plugin optimize

@elasticmachine
Copy link
Contributor

Can one of the admins verify this patch?

@jbudz
Copy link
Member

jbudz commented Nov 16, 2017

This is awesome and much needed, thanks for the PR @gwintzer.

A couple discussion points, /cc @tylersmalley :

  • My ideal version of this would be to make optimization opt in for plugin installation. We get tons of bugs filed for Permission errors in packages after server optimizing #8818 and this would cut down on nearly all of them.
  • Plugin installation validates kibana.yml due to the optimize task, there's been a few related bugs to setting kibana.yml before installation
  • I'd like to see a separate script for optimization to be as clear as possible for the standalone task - it fits under bin/kibana and bin/kibana-plugin so instead of supporting both we can be explicit with bin/kibana-optimize.

usage:

bin/kibana-plugin install foo --optimize
bin/kibana-optimize

Thoughts?

@tylersmalley
Copy link
Contributor

tylersmalley commented Nov 16, 2017

@jbudz, I agree with all of your points but changing the default to not optimize during plugin installation might be considered a breaking change. I would be for backporting this to 6.0, and in 7 flipping the defaults. Though, hopefully then we will have removed the optimize process altogether.

@tylersmalley tylersmalley self-requested a review November 16, 2017 15:48
@FireBurn
Copy link

Here's the backport to 6.1, I have ones for 6.0 and 5.6 if anyone else needs them https://gist.github.com/FireBurn/2ecaaff4c40a6dd9bb865f732a9754a7

@theikkila
Copy link

Any idea when you're gonna merge this?

@hierony94
Copy link

hierony94 commented Jan 18, 2018

I hope this feature will release soon.

{"type":"log","@timestamp":"2018-01-18T04:34:36Z","tags":["info","optimize"],"pid":1,"message":"Optimization of bundles for kibana, timelion and status_page complete in **466.53 seconds**"}

@CpuID
Copy link

CpuID commented Jan 28, 2018

+1 to getting this merged sometime soonish

@Stono
Copy link

Stono commented Jan 30, 2018

+1, this is a pain in the arse and results in long builds for us!

@pchanas
Copy link

pchanas commented Feb 8, 2018

+1 I do confirm the pain

@jcoeltjen
Copy link

👍 , we be a great feature for us! Then we would be able to remove some nasty workaround hacks...

@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@joshdover
Copy link
Contributor

Closing since we've implemented this over in #16302

@joshdover joshdover closed this Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.