Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Add missing IntlProvider to unit test #150137

Merged
merged 1 commit into from
Feb 2, 2023
Merged

[APM] Add missing IntlProvider to unit test #150137

merged 1 commit into from
Feb 2, 2023

Conversation

sorenlouv
Copy link
Member

Jest tests in APM are currently failing with:

Error: Uncaught [Error: [React Intl] Could not find required `intl` object. <IntlProvider> needs to exist in the component ancestry. Using default message as fallback.]

Adding the IntlProvider fixes the problem

@sorenlouv sorenlouv requested a review from a team as a code owner February 2, 2023 09:15
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Feb 2, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@sorenlouv sorenlouv added the release_note:skip Skip the PR/issue when compiling release notes label Feb 2, 2023
@sorenlouv sorenlouv enabled auto-merge (squash) February 2, 2023 09:29
@sorenlouv
Copy link
Member Author

Buildkite, test this

@sorenlouv sorenlouv force-pushed the fix-broken-unit-test branch from 998a3ac to d218cc9 Compare February 2, 2023 11:14
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💔 Build #105022 failed 998a3ac7b2beb5b7ddae4c5b59417cf47f76955d
  • 💔 Build #105002 failed 998a3ac7b2beb5b7ddae4c5b59417cf47f76955d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit 5aafc55 into elastic:main Feb 2, 2023
@kibanamachine kibanamachine added v8.7.0 backport:skip This commit does not require backporting labels Feb 2, 2023
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this pull request Feb 6, 2023
@sorenlouv @kqualters-elastic
[APM] Add missing IntlProvider to unit test (elastic#150137)
312db24 
Jest tests in APM are currently failing with:

```
Error: Uncaught [Error: [React Intl] Could not find required `intl` object. <IntlProvider> needs to exist in the component ancestry. Using default message as fallback.]
```

Adding the `IntlProvider` fixes the problem
@sorenlouv sorenlouv deleted the fix-broken-unit-test branch April 12, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achyutjhunjhunwala achyutjhunjhunwala achyutjhunjhunwala approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sorenlouv @elasticmachine @kibana-ci @achyutjhunjhunwala @kibanamachine