[data view editor] Fix data view timestamp validation #150398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkime
changed the title
mattkime
added
Feature:Data Views
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
mattkime
added
the
release_note:skip
|
Hi @mattkime, Please check this scenario:
|
kertal
added
release_note:fix
and removed
bug
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @mattkime |
jughosta
approved these changes
Jun 30, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 30, 2023
## Summary Previously - If you changed a data view's index pattern AND the new pattern didn't contain the timestamp field, you'd see a blank timestamp field and it would let you save. The data view would have been saved with the previous timestamp field which doesn't exist. Now - The timestamp validator checks to make sure the selected timestamp field is in the list of available options. This is helpful because it keeps the previous timestamp value in case you do select an index pattern that contains it. Closes: elastic#150219 (cherry picked from commit 646539c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 30, 2023
…#160990) # Backport This will backport the following commits from `main` to `8.9`: - [[data view editor] Fix data view timestamp validation (#150398)](#150398) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthew Kime","email":"matt@mattki.me"},"sourceCommit":{"committedDate":"2023-06-30T12:29:44Z","message":"[data view editor] Fix data view timestamp validation (#150398)\n\n## Summary\r\n\r\nPreviously - If you changed a data view's index pattern AND the new\r\npattern didn't contain the timestamp field, you'd see a blank timestamp\r\nfield and it would let you save. The data view would have been saved\r\nwith the previous timestamp field which doesn't exist.\r\n\r\nNow - The timestamp validator checks to make sure the selected timestamp\r\nfield is in the list of available options. This is helpful because it\r\nkeeps the previous timestamp value in case you do select an index\r\npattern that contains it.\r\n\r\nCloses: #150219 Views","Feature:Kibana Management","Team:DataDiscovery","backport:prev-minor","v8.10.0"],"number":150398,"url":"#150398 view editor] Fix data view timestamp validation (#150398)\n\n## Summary\r\n\r\nPreviously - If you changed a data view's index pattern AND the new\r\npattern didn't contain the timestamp field, you'd see a blank timestamp\r\nfield and it would let you save. The data view would have been saved\r\nwith the previous timestamp field which doesn't exist.\r\n\r\nNow - The timestamp validator checks to make sure the selected timestamp\r\nfield is in the list of available options. This is helpful because it\r\nkeeps the previous timestamp value in case you do select an index\r\npattern that contains it.\r\n\r\nCloses: #150219 view editor] Fix data view timestamp validation (#150398)\n\n## Summary\r\n\r\nPreviously - If you changed a data view's index pattern AND the new\r\npattern didn't contain the timestamp field, you'd see a blank timestamp\r\nfield and it would let you save. The data view would have been saved\r\nwith the previous timestamp field which doesn't exist.\r\n\r\nNow - The timestamp validator checks to make sure the selected timestamp\r\nfield is in the list of available options. This is helpful because it\r\nkeeps the previous timestamp value in case you do select an index\r\npattern that contains it.\r\n\r\nCloses: #150219"}}]}] BACKPORT--> Co-authored-by: Matthew Kime <matt@mattki.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously - If you changed a data view's index pattern AND the new pattern didn't contain the timestamp field, you'd see a blank timestamp field and it would let you save. The data view would have been saved with the previous timestamp field which doesn't exist.
Now - The timestamp validator checks to make sure the selected timestamp field is in the list of available options. This is helpful because it keeps the previous timestamp value in case you do select an index pattern that contains it.
Closes: #150219
Checklist