[Defend Workflows] Fix: proper regexp test for dynamic parameters presence #150696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szwarckonrad
added
bug
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
szwarckonrad
changed the title
patrykkopycinski
approved these changes
Feb 9, 2023
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 9, 2023
…sence (elastic#150696) (cherry picked from commit b5dde1f)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 9, 2023
…rs presence (#150696) (#150749) # Backport This will backport the following commits from `main` to `8.7`: - [[Defend Workflows] Fix: proper regexp test for dynamic parameters presence (#150696)](#150696) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Konrad Szwarc","email":"konrad.szwarc@elastic.co"},"sourceCommit":{"committedDate":"2023-02-09T17:02:53Z","message":"[Defend Workflows] Fix: proper regexp test for dynamic parameters presence (#150696)","sha":"b5dde1fcf5f54479906542a178cb87c616c7cb4f","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Defend Workflows","v8.7.0","v8.6.2","v8.8.0"],"number":150696,"url":"https://github.com/elastic/kibana/pull/150696","mergeCommit":{"message":"[Defend Workflows] Fix: proper regexp test for dynamic parameters presence (#150696)","sha":"b5dde1fcf5f54479906542a178cb87c616c7cb4f"}},"sourceBranch":"main","suggestedTargetBranches":["8.7","8.6"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.6","label":"v8.6.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150696","number":150696,"mergeCommit":{"message":"[Defend Workflows] Fix: proper regexp test for dynamic parameters presence (#150696)","sha":"b5dde1fcf5f54479906542a178cb87c616c7cb4f"}}]}] BACKPORT--> Co-authored-by: Konrad Szwarc <konrad.szwarc@elastic.co>
|
Dynamic parameters are not part of 8.6, so the backport to 8.6.x is not required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
When both Pack and Single Query osQuery response actions were defined within rule's Response Actions, parameter of Single Query wasn't replaced with event data.
Cause:
Due to regexp test inconsistent behaviour (known bug, read more here) dynamic parameter was being found for pack queries but for the following, single query, was being set to false negative.
Fix:
Wrapping regexp string in RegExp constructor fixes the issue.
Before:
After:
