Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Alerts] adds data generator to functional tests #151192

Merged
merged 17 commits into from
Mar 6, 2023
Merged

[Security Solution][Alerts] adds data generator to functional tests #151192

merged 17 commits into from
Mar 6, 2023

Conversation

vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Feb 14, 2023 •
edited
Loading

Summary

@vitaliidm vitaliidm self-assigned this Feb 15, 2023
@vitaliidm vitaliidm added v8.8.0 test-docs Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Alerts Security Detection Alerts Area Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting and removed test-docs labels Feb 15, 2023
@vitaliidm vitaliidm mentioned this pull request Feb 16, 2023
Closed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

@vitaliidm vitaliidm marked this pull request as ready for review February 21, 2023 15:03
@vitaliidm vitaliidm requested a review from a team as a code owner February 21, 2023 15:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@vitaliidm vitaliidm requested a review from a team February 21, 2023 15:04
e40pud
e40pud approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@e40pud e40pud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome changes!! LGTM

@vitaliidm vitaliidm merged commit 2858052 into elastic:main Mar 6, 2023
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
@vitaliidm @bmorelli25
[Security Solution][Alerts] adds data generator to functional tests (e…
830ef37 
…lastic#151192)

## Summary

- partially addresses elastic#145406 by
adding dataGenerator
- once dataGenerator API agreed, we can proceed with tests refactoring
if needed
- added README how to use data generating tools -
https://github.com/vitaliidm/kibana/blob/alerts/functional-tests-data-generator/x-pack/test/detection_engine_api_integration/utils/data_generator/README.md
- partially migrated a few `new terms` tests, to give an example how to
use the created tool
@vitaliidm vitaliidm deleted the alerts/functional-tests-data-generator branch March 4, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e40pud e40pud e40pud approved these changes

Assignees

@vitaliidm vitaliidm

Labels
backport:skip This commit does not require backporting refactoring release_note:skip Skip the PR/issue when compiling release notes Team:Detection Alerts Security Detection Alerts Area Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vitaliidm @kibana-ci @elasticmachine @e40pud