Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infrastructure UI] Functional tests Hosts View Alerts tab #152228

Merged
merged 7 commits into from
Feb 28, 2023
Merged

[Infrastructure UI] Functional tests Hosts View Alerts tab #152228

merged 7 commits into from
Feb 28, 2023

Conversation

tonyghiani
Copy link
Contributor

@tonyghiani tonyghiani commented Feb 27, 2023 •
edited
Loading

📓 Summary

Closes #150741

  • Add infra alerts mock file
  • Add initial functional tests for the Alerts Tab
  • Remove duplicated tests by the role as they are inclusive of the same privileges
  • Restructure existing tests to cut execution time by ~50%
Before After
before after

@tonyghiani tonyghiani added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v8.8.0 labels Feb 27, 2023
@tonyghiani tonyghiani marked this pull request as ready for review February 28, 2023 09:59
@tonyghiani tonyghiani requested a review from a team as a code owner February 28, 2023 09:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.3MB 1.3MB +83.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 428 430 +2

Total ESLint disabled count

id before after diff
securitySolution 506 508 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

crespocarlos
crespocarlos approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for all the improvements.

@tonyghiani tonyghiani merged commit 3b6177d into elastic:main Feb 28, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 28, 2023
@tonyghiani tonyghiani deleted the 150741-alerts-tab-functional-tests branch February 28, 2023 16:10
@tonyghiani tonyghiani mentioned this pull request Mar 1, 2023
Closed
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
@tonyghiani @bmorelli25
[Infrastructure UI] Functional tests Hosts View Alerts tab (elastic#1…
23620e8 
…52228)

## 📓 Summary

Closes elastic#150741 

- Add infra alerts mock file
- Add initial functional tests for the Alerts Tab
- Remove duplicated tests by the role as they are inclusive of the same
privileges
- Restructure existing tests to **cut execution time by ~50%**

Before             |  After
:-------------------------:|:-------------------------:
<img width="164" alt="before"
src="https://user-images.githubusercontent.com/34506779/221805295-9de8c467-e212-4cb7-b270-bd8d10063e0f.png">
| <img width="161" alt="after"
src="https://user-images.githubusercontent.com/34506779/221805315-a4a105df-6b5b-4cb4-bdeb-8384f0459f91.png">

---------

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infrastructure UI] Add functional tests for Hosts Alerts tab
5 participants
@tonyghiani @elasticmachine @kibana-ci @crespocarlos @kibanamachine