Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Fix flaky test for update api key tests #152277

Merged
merged 12 commits into from
Feb 28, 2023
Merged

[RAM] Fix flaky test for update api key tests #152277

merged 12 commits into from
Feb 28, 2023

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Feb 27, 2023

Summary

Bring back update api key test

Checklist

@XavierM XavierM added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0 labels Feb 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@XavierM XavierM added the release_note:skip Skip the PR/issue when compiling release notes label Feb 27, 2023
@XavierM XavierM requested a review from a team as a code owner February 27, 2023 20:14
@XavierM XavierM mentioned this pull request Feb 28, 2023
Closed
JiaweiWu
JiaweiWu approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@JiaweiWu JiaweiWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! much cleaner

@XavierM XavierM enabled auto-merge (squash) February 28, 2023 20:20
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 428 430 +2

Total ESLint disabled count

id before after diff
securitySolution 506 508 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit a87f440 into elastic:main Feb 28, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 28, 2023
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
@XavierM @bmorelli25
[RAM] Fix flaky test for update api key tests (elastic#152277)
07f4ad9 
## Summary

Bring back update api key test


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guskovaue guskovaue guskovaue left review comments

@JiaweiWu JiaweiWu JiaweiWu approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@XavierM @elasticmachine @kibana-ci @guskovaue @JiaweiWu @kibanamachine