[Infrastructure UI] Improve alerts query and fix import #152549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyghiani
added
Team:Infra Monitoring UI - DEPRECATED
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
crespocarlos
approved these changes
Mar 6, 2023
|
|
||
| return buildEsQuery(undefined, queries, filters); | ||
| return buildEsQuery(undefined, [], filters); |
There was a problem hiding this comment.
Why aren't we passing a data view here? Is it because we have more control over the filters that are passed to it?
There was a problem hiding this comment.
As done in the observability plugin, the data view was not passed because we need more control over those filters yeah! This way we are just taking care of passing the list of hosts, the data range and the alert status, without the need to retrieve the alerts data view.
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
## 📓 Summary Closes elastic#152544 The issue was caused by a wrong import, where we were directly importing the hook implementation instead of the context hook exposed by `constate`. This PR also improves a bit the alerts status filtering switching from `match_phrase` to a `term` query. ## 🧪 Testing - Navigate to the Hosts View - Open dev tools - Refresh the page or trigger a new search - Verify the `/snapshot` API is called once to retrieve the table metrics --------- Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 Summary
Closes #152544
The issue was caused by a wrong import, where we were directly importing the hook implementation instead of the context hook exposed by
constate.This PR also improves a bit the alerts status filtering switching from
match_phraseto atermquery.🧪 Testing
/snapshotAPI is called once to retrieve the table metrics