-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cases] Detail View Attachments Table #152941
Merged
adcoelho
merged 26 commits into
elastic:cases-detail-view-files-tab
from
adcoelho:cases-detail-attachments-table
Mar 27, 2023
Merged
Changes from 24 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
6095d8a
[Cases] Initial commit.
adcoelho 1948296
Include file context. Create Add file modal.
adcoelho 45a60d3
List attachments.
adcoelho 2c55946
Rebase to use new file kinds in cases.
adcoelho c14555e
Addressing PR comments.
adcoelho fa72cd9
Addressing PR comments 2.
adcoelho fef9094
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 9a225e4
Merge remote-tracking branch 'upstream/cases-detail-view-files-tab' i…
adcoelho a5a0095
Passed owner in file metadata.
adcoelho 6222a84
Merge remote-tracking branch 'upstream/cases-detail-view-files-tab' i…
adcoelho c2a4499
Fix type error on observability plugin.
adcoelho b48f33b
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 9df97e3
Fixed translation issue
adcoelho 6df7064
Created the FilesUtilityBar.
adcoelho 32434d0
Updated mock in test providers.
adcoelho 714d501
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 1c03756
Include showDanger in useCasesToast.
adcoelho af1f15f
Fix AddFile button in empty FilesTable.
adcoelho 3f1d76f
Use isPreviousData in FilesTable pagination.
adcoelho df1702c
Merge remote-tracking branch 'upstream/cases-detail-view-files-tab' i…
adcoelho 95926fc
Change files count information in files table.
adcoelho 81b41d1
Add FilePreview tests.
adcoelho 68c3047
Changed implementation of isRegisteredOwner.
adcoelho e2ad7a5
Fixed failing jest tests.
adcoelho 9fefef4
Add pagination tests for case view files.
adcoelho bccf790
AddFile disabled if user has no create permission.
adcoelho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be missing the picture here, Why do we need
getFilesClient
separately in selector modal?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if sometimes it isn't used (like in the selector modal that doesn't show the case detail view where the files tab is)
the
CasesContext
wraps its children in theFilesContextProvider
that unfortunately needs the files client.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh okay 👍