-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infrastructure UI] Integrated the logs tab to the Hosts View #152995
[Infrastructure UI] Integrated the logs tab to the Hosts View #152995
Conversation
…egrate-logs-tab-in-hosts-view
…egrate-logs-tab-in-hosts-view
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, It works fine 🙌 I added some questions/comments and just spotted some things that I am not sure should be covered here:
-
Should we support auto-complete like the other search bar because when I am typing I see this validation error message instead of a hostname suggestion (when I put the name it is showing the logs correctly)?
It is similar in inventory so I am not sure 🤔 -
Regarding the history issue we checked with the logs stream page: this will be something checked on the logs page separately right?
x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/logs/logs_tab_content.tsx
Show resolved
Hide resolved
x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/logs/logs_tab_content.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/logs/logs_tab_content.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/public/pages/metrics/hosts/hooks/use_logs_search_url_state.ts
Show resolved
Hide resolved
x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/logs/logs_tab_content.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change. I checked it and everything works as expected. I would only suggest - if possible - covering this new tab in our functional test in this PR.
Regarding the URL generated to link to the Logs UI, I was wondering if it would be possible to build the querystring to populate the unified search filters with the host names. I'm not sure if this is possible and/or if it's an easy change, but I think it would provide better UX if the user wants to remove a host from the list.
Another thing is that if you click on the browser back button, it doesn't return to the Hosts view. Apparently, the Logs UI adds items to the browser history - I guess that's what @jennypavlova mentioned above, right?
x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/logs/logs_tab_content.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/logs/logs_tab_content.tsx
Show resolved
Hide resolved
x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/logs/logs_tab_content.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/logs/logs_link_to_stream.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/logs/logs_link_to_stream.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/logs/index.ts
Show resolved
Hide resolved
x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/tabs.tsx
Outdated
Show resolved
Hide resolved
…egrate-logs-tab-in-hosts-view
…egrate-logs-tab-in-hosts-view
@jennypavlova I have already discussed this with Nathan and we agreed to keep it this way for now as much work in the logs is coming in the future.
I am fixing this now and will be part of this PR, but yes it will be fixed in the logs page as discussed with Kerry
@crespocarlos yes its the same, I discussed it with Kerry and will get this fixed 👍
I was discussing this with Marco earlier and the plan was to cover it as part of this ticket. |
Right! The downside is that we'll be vulnerable to changes that could potentially cause problems with this feature. As long as it's mapped there it's ok :). But to avoid adding items to that list of debts, if the feature is done and no further development is needed, I'd consider including tests in the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! I ran another round of tests and noticed a couple of things, mostly questions about how the tab should behave in certain scenarios.
x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/logs/logs_tab_content.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/logs/logs_tab_content.tsx
Show resolved
Hide resolved
x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/logs/logs_tab_content.tsx
Show resolved
Hide resolved
@elasticmachine merge upstream |
merge conflict between base and head |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits that I didn't notice in my previous reviews, but the PR looks good.
x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/logs/logs_tab_content.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/logs/logs_tab_content.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/public/pages/metrics/hosts/components/tabs/logs/logs_tab_content.tsx
Outdated
Show resolved
Hide resolved
…nagement [Infrastructure UI] Fix HTTP request state management
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this change and applying the suggestions :)
closes #957
closes #958
closes #959
Summary
This PR is for integrating the logs tab in the Hosts view and adding a search bar to allow further filtering the logs, it also enables navigating to the Logs stream view using an Open in logs link.
Demo
Screen.Recording.2023-03-20.at.11.40.29.mov
Next Steps