Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visualizations: cleanup saved object mappings #153142

Merged
merged 7 commits into from
Mar 27, 2023
Merged

visualizations: cleanup saved object mappings #153142

merged 7 commits into from
Mar 27, 2023

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Mar 11, 2023 •
edited
Loading

Summary

Related to #149102

Subset of the global cleanup attempt in #153070

Dry run for cleaning up visualizations mappings

Checklist

@TinaHeiligers TinaHeiligers added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.8.0 labels Mar 11, 2023
@TinaHeiligers
Copy link
Contributor Author

@elastic/kibana-visualizations if CI goes green, we can use this PR to clean up the mappings.
If not, it means there's a direct reference to the fields and we'll need to decide how to handle that.

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers marked this pull request as ready for review March 21, 2023 13:56
@TinaHeiligers TinaHeiligers requested review from a team as code owners March 21, 2023 13:56
stratoula
stratoula reviewed Mar 23, 2023
View reviewed changes
src/plugins/visualizations/server/saved_objects/visualization.ts Outdated
version: { type: 'integer' },
visState: { type: 'text', index: false },
// visState: { type: 'text', index: false },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TinaHeiligers why have you kept them commented out?

Copy link
Contributor Author

@TinaHeiligers TinaHeiligers Mar 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented out the field as a dry run, the delete commit didn't make it. Fixing it now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 75c3b99

@TinaHeiligers
Copy link
Contributor Author

@elastic/kibana-visualizations can we get a review please?

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers enabled auto-merge (squash) March 23, 2023 14:30
@stratoula
Copy link
Contributor

@TinaHeiligers why this jest integration test has started failing now? 🤔

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/saved-objects-service.html#_mappings

id before after diff
visualization 9 4 -5
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor Author

@TinaHeiligers why this jest integration test has started failing now? 🤔

@stratoula All fixed with a test rerun 😄

stratoula
stratoula approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@TinaHeiligers TinaHeiligers merged commit a73bf87 into elastic:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TinaHeiligers @stratoula @kibana-ci @pgayvallet @kibanamachine