[Defend Workflows][Bug] Case flyout z-index #153219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szwarckonrad
added
bug
szwarckonrad
changed the title
szwarckonrad
requested review from
tomsonpl and
patrykkopycinski
and removed request for
patrykkopycinski
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
jonathan-buttner
added
ci:cloud-deploy
There was a problem hiding this comment.
Thanks for taking a look at the issue. It looks like the changes have affected how the global nav header is shown. With the new changes the global nav header shows up behind the flyout and is grayed out where as previously it was not grayed out.
Here's with the changes
Here's how the flyout looked without the z-index changes
|
@jonathan-buttner do you think it's actually a bad thing? :P why should we see a navbar while using a modal? |
Yeah I think we want the header to be selectable while using a flyout. That's consistent with how the rest of Kibana works Security solution example
Discover example
|
|
@jonathan-buttner Ok it should be fine now 👍 we changed above to below, and the issue is still fixed :elastic-heart: |
3 tasks
x-pack/plugins/security_solution/public/timelines/components/flyout/pane/index.tsx
Show resolved
Hide resolved
kqualters-elastic
approved these changes
May 1, 2023
|
This PR fixes this bug #156147. The fix is really crucial to get in 8.8. |
patrykkopycinski
added
ci:skip-cypress-osquery
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
angorayc
approved these changes
May 3, 2023
nkhristinin
reviewed
May 3, 2023
| @@ -37,7 +37,6 @@ const MyEuiModal = styled(EuiModal)` | |||
| height: auto !important; | |||
| max-width: 718px; | |||
| } | |||
| z-index: 99999999; | |||
There was a problem hiding this comment.
Not sure, how to test this case
nkhristinin
approved these changes
May 3, 2023
There was a problem hiding this comment.
tested locally exceptions.
Make 1 comment about case I am not sure how to test https://github.com/elastic/kibana/pull/153219/files?file-filters%5B%5D=.snap&file-filters%5B%5D=.ts&file-filters%5B%5D=.tsx&owned-by%5B%5D=nkhristinin&show-viewed-files=true#r1183485749
maybe @dhurley14 can help
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 3, 2023
Fixes elastic/security-team#6228 5000 `z-index` set in `create-case-flyout-mask-overlay` is being overwritten by `euiOverlayMask-belowHeader` with a value of 1000. This causes **Case flyout** to be under the already opened **Osquery flyout** This PR includes cleanup in flyouts renders - we removed unnecessary `maskProps` as well as z-indexes that were explicitly set even though flyout component manages them itself.  --------- Co-authored-by: Tomasz Ciecierski <ciecierskitomek@gmail.com> Co-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co> Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit d8fe39c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kevinlog
pushed a commit
that referenced
this pull request
May 3, 2023
# Backport This will backport the following commits from `main` to `8.8`: - [[Defend Workflows][Bug] Case flyout z-index (#153219)](#153219) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Konrad Szwarc","email":"konrad.szwarc@elastic.co"},"sourceCommit":{"committedDate":"2023-05-03T10:30:13Z","message":"[Defend Workflows][Bug] Case flyout z-index (#153219)\n\nFixes https://github.com/elastic/security-team/issues/6228\r\n\r\n5000 `z-index` set in `create-case-flyout-mask-overlay` is being\r\noverwritten by `euiOverlayMask-belowHeader` with a value of 1000. This\r\ncauses **Case flyout** to be under the already opened **Osquery flyout**\r\n\r\nThis PR includes cleanup in flyouts renders - we removed unnecessary\r\n`maskProps` as well as z-indexes that were explicitly set even though\r\nflyout component manages them itself.\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Tomasz Ciecierski <ciecierskitomek@gmail.com>\r\nCo-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co>\r\nCo-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"d8fe39c18d9df7acb00a82515f5a41a6e4111c59","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Defend Workflows","Feature:Osquery","ci:all-cypress-suites","v8.8.0","ci:skip-cypress-osquery","v8.9.0"],"number":153219,"url":"https://github.com/elastic/kibana/pull/153219","mergeCommit":{"message":"[Defend Workflows][Bug] Case flyout z-index (#153219)\n\nFixes https://github.com/elastic/security-team/issues/6228\r\n\r\n5000 `z-index` set in `create-case-flyout-mask-overlay` is being\r\noverwritten by `euiOverlayMask-belowHeader` with a value of 1000. This\r\ncauses **Case flyout** to be under the already opened **Osquery flyout**\r\n\r\nThis PR includes cleanup in flyouts renders - we removed unnecessary\r\n`maskProps` as well as z-indexes that were explicitly set even though\r\nflyout component manages them itself.\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Tomasz Ciecierski <ciecierskitomek@gmail.com>\r\nCo-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co>\r\nCo-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"d8fe39c18d9df7acb00a82515f5a41a6e4111c59"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/153219","number":153219,"mergeCommit":{"message":"[Defend Workflows][Bug] Case flyout z-index (#153219)\n\nFixes https://github.com/elastic/security-team/issues/6228\r\n\r\n5000 `z-index` set in `create-case-flyout-mask-overlay` is being\r\noverwritten by `euiOverlayMask-belowHeader` with a value of 1000. This\r\ncauses **Case flyout** to be under the already opened **Osquery flyout**\r\n\r\nThis PR includes cleanup in flyouts renders - we removed unnecessary\r\n`maskProps` as well as z-indexes that were explicitly set even though\r\nflyout component manages them itself.\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Tomasz Ciecierski <ciecierskitomek@gmail.com>\r\nCo-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co>\r\nCo-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"d8fe39c18d9df7acb00a82515f5a41a6e4111c59"}}]}] BACKPORT--> Co-authored-by: Konrad Szwarc <konrad.szwarc@elastic.co>
\r\n\r\n---------\r\n\r\nCo-authored-by){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/elastic/security-team/issues/6228
5000
z-indexset increate-case-flyout-mask-overlayis being overwritten byeuiOverlayMask-belowHeaderwith a value of 1000. This causes Case flyout to be under the already opened Osquery flyoutThis PR includes cleanup in flyouts renders - we removed unnecessary
maskPropsas well as z-indexes that were explicitly set even though flyout component manages them itself.