Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Display total next to files tab in case detail view #153853

Merged

Conversation

adcoelho
Copy link
Contributor

Merging to a feature branch

Summary

In this PR we display the number of files attached to a case in the Files tab in the case detail view.

filestabcount.mov

Created tests for it in case view tabs tests.
Fixed permissions in AddFile.
Removed unnecessary lines in files utils tests.
@adcoelho adcoelho added enhancement New value added to drive a business result Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.8.0 labels Mar 28, 2023
@adcoelho adcoelho self-assigned this Mar 28, 2023
@adcoelho adcoelho requested a review from a team as a code owner March 28, 2023 10:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Use select in useGetCaseFileStats.
@adcoelho adcoelho force-pushed the cases-detail-file-count branch from b5b376a to 721ef94 Compare March 31, 2023 09:56
@kibana-ci
Copy link
Collaborator

kibana-ci commented Mar 31, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [294f1d5]

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @adcoelho

@adcoelho adcoelho merged commit 5dfc418 into elastic:cases-detail-view-files-tab Mar 31, 2023
@cnasikas cnasikas mentioned this pull request Apr 3, 2023
5 tasks
adcoelho added a commit that referenced this pull request Apr 18, 2023
Fixes #151595 

## Summary

In this PR we will be merging a feature branch into `main`.

This feature branch is a collection of several different PRs with file
functionality for cases.

- #152941
- #153957
- #154432
- #153853

Most of the code was already reviewed so this will mainly be used for
testing.

- Files tab in the case detail view.
- Attach files to a case.
- View a list of all files attached to a case (with pagination).
- Preview image files attached to a case.
- Search for files attached to a case by file name.
- Download files attached to a case.
- Users are now able to see file activity in the case detail view.
- Image files have a different icon and a clickable file name to
preview.
- Other files have a standard "document" icon and the name is not
clickable.
- The file can be downloaded by clicking the download icon.

## Release notes

Support file attachments in Cases.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants