-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cases] Display total next to files tab in case detail view #153853
Merged
adcoelho
merged 4 commits into
elastic:cases-detail-view-files-tab
from
adcoelho:cases-detail-file-count
Mar 31, 2023
Merged
[Cases] Display total next to files tab in case detail view #153853
adcoelho
merged 4 commits into
elastic:cases-detail-view-files-tab
from
adcoelho:cases-detail-file-count
Mar 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created tests for it in case view tabs tests. Fixed permissions in AddFile. Removed unnecessary lines in files utils tests.
adcoelho
added
enhancement
New value added to drive a business result
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
Feature:Cases
Cases feature
v8.8.0
labels
Mar 28, 2023
Pinging @elastic/response-ops (Team:ResponseOps) |
Pinging @elastic/response-ops-cases (Feature:Cases) |
cnasikas
reviewed
Mar 28, 2023
cnasikas
reviewed
Mar 28, 2023
cnasikas
reviewed
Mar 28, 2023
x-pack/plugins/cases/public/components/case_view/case_view_tabs.test.tsx
Show resolved
Hide resolved
cnasikas
reviewed
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
x-pack/plugins/cases/public/components/case_view/case_view_tabs.test.tsx
Show resolved
Hide resolved
Use select in useGetCaseFileStats.
cnasikas
approved these changes
Mar 30, 2023
adcoelho
force-pushed
the
cases-detail-file-count
branch
from
March 31, 2023 09:56
b5b376a
to
721ef94
Compare
💔 Build FailedFailed CI Steps
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @adcoelho |
5 tasks
adcoelho
added a commit
that referenced
this pull request
Apr 18, 2023
Fixes #151595 ## Summary In this PR we will be merging a feature branch into `main`. This feature branch is a collection of several different PRs with file functionality for cases. - #152941 - #153957 - #154432 - #153853 Most of the code was already reviewed so this will mainly be used for testing. - Files tab in the case detail view. - Attach files to a case. - View a list of all files attached to a case (with pagination). - Preview image files attached to a case. - Search for files attached to a case by file name. - Download files attached to a case. - Users are now able to see file activity in the case detail view. - Image files have a different icon and a clickable file name to preview. - Other files have a standard "document" icon and the name is not clickable. - The file can be downloaded by clicking the download icon. ## Release notes Support file attachments in Cases. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New value added to drive a business result
Feature:Cases
Cases feature
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
v8.8.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging to a feature branch
Summary
In this PR we display the number of files attached to a case in the Files tab in the case detail view.
filestabcount.mov