Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix accessibility warnings in notifications and memory usage chart #153876

Merged
merged 2 commits into from
Mar 28, 2023
Merged

[ML] Fix accessibility warnings in notifications and memory usage chart #153876

merged 2 commits into from
Mar 28, 2023

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Mar 28, 2023 •
edited
Loading

Summary

Fixes a couple of accessibility warnings - one for the unread notifications indicator in the sidebar nav, and one on the indicator for the maximum memory for ML native process on the memory usage chart.

Unread notifications indicator

Fix adds a role attribute which is needed when aria-label is used on a <div>.
image

Memory usage chart

Fix adds an aria-label attribute to the max memory EuiIcon which is rendered as a button.
image

Checklist

  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

Fixes #153592
Fixes #153596

@peteharverson peteharverson added review :ml release_note:skip Skip the PR/issue when compiling release notes v8.8.0 labels Mar 28, 2023
@peteharverson peteharverson requested a review from a team as a code owner March 28, 2023 15:05
@peteharverson peteharverson self-assigned this Mar 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

darnautov
darnautov approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@peteharverson
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.4MB 3.4MB +210.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @peteharverson

@peteharverson peteharverson merged commit 67a5d06 into elastic:main Mar 28, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 28, 2023
@peteharverson peteharverson deleted the ml-overview-page-a11y-fixes branch March 28, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

Assignees

@peteharverson peteharverson

Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes review v8.8.0
Projects
None yet
Milestone
No milestone
6 participants
@peteharverson @elasticmachine @kibana-ci @darnautov @alvarezmelissa87 @kibanamachine