Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Search Applications - Switch to only show conflicts on schema page #154149

Merged
merged 3 commits into from
Apr 3, 2023
Merged

[Enterprise Search] Search Applications - Switch to only show conflicts on schema page #154149

merged 3 commits into from
Apr 3, 2023

Conversation

sloanelybutsurely
Copy link

Summary

Screen.Recording.2023-03-31.at.8.44.49.AM.mov

Checklist

Delete any items that are not applicable to this PR.

@sloanelybutsurely sloanelybutsurely added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch labels Mar 31, 2023
@sloanelybutsurely sloanelybutsurely requested a review from a team March 31, 2023 12:46
@sloanelybutsurely sloanelybutsurely force-pushed the ent-search-3953-only-conflicts-filter branch from e79a93a to 254c9ae Compare April 3, 2023 14:07
@sloanelybutsurely sloanelybutsurely requested review from sphilipse, saarikabhasi and a team April 3, 2023 15:13
sphilipse
sphilipse approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

saarikabhasi
saarikabhasi approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@saarikabhasi saarikabhasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean, LGTM! 💯

Sloane Perrault added 3 commits April 3, 2023 11:51
add switch to only show conflicts
730b88d
remove setItemIdToExpandedRowMap from callback deps
fd5393b 
react guarantees a stable function identity for setter functions
returned from `useState` calls.
flip condition to avoid boolean negation
2523686 
as requested by: elastic#154149 (comment)
@sloanelybutsurely sloanelybutsurely force-pushed the ent-search-3953-only-conflicts-filter branch from e08b779 to 2523686 Compare April 3, 2023 15:51
@sloanelybutsurely sloanelybutsurely enabled auto-merge (squash) April 3, 2023 15:51
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.2MB 2.2MB +396.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

  • 💚 Build #117063 succeeded e79a93a1d0fddbcd27c2bce370b24f671d49271e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sloanelybutsurely sloanelybutsurely merged commit 3948f61 into elastic:main Apr 3, 2023
@kibanamachine kibanamachine added v8.8.0 backport:skip This commit does not require backporting labels Apr 3, 2023
@sloanelybutsurely sloanelybutsurely deleted the ent-search-3953-only-conflicts-filter branch April 3, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphilipse sphilipse sphilipse approved these changes

@saarikabhasi saarikabhasi saarikabhasi approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sloanelybutsurely @kibana-ci @saarikabhasi @sphilipse @kibanamachine