Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update search session saved object mappings #154401

Merged
merged 5 commits into from
Apr 10, 2023
Merged

Update search session saved object mappings #154401

merged 5 commits into from
Apr 10, 2023

Conversation

lukasolson
Copy link
Member

Summary

Part of #153070.

Cleans up the saved object mappings for search session saved objects. Removes the non-searchable/sortable properties from the mappings property and introduces a schema property for validation.

@lukasolson lukasolson added Feature:Search Querying infrastructure in Kibana chore Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:Search Sessions v8.8.0 labels Apr 4, 2023
@lukasolson lukasolson self-assigned this Apr 4, 2023
@lukasolson lukasolson requested review from a team as code owners April 4, 2023 22:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@lukasolson lukasolson added the release_note:skip Skip the PR/issue when compiling release notes label Apr 4, 2023
davismcphee
davismcphee approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the mappings cleanup!

@lukasolson lukasolson requested a review from a team as a code owner April 6, 2023 20:26
@lukasolson lukasolson enabled auto-merge (squash) April 6, 2023 23:03
TinaHeiligers
TinaHeiligers approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasolson
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/saved-objects-service.html#_mappings

id before after diff
search-session 12 6 -6
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukasolson

@lukasolson lukasolson merged commit 8770a1c into elastic:main Apr 10, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 10, 2023
drewdaemon
drewdaemon reviewed Apr 12, 2023
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved since Discover team owns search

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewdaemon drewdaemon drewdaemon left review comments

@davismcphee davismcphee davismcphee approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees

@lukasolson lukasolson

Labels
backport:skip This commit does not require backporting chore Feature:Search Sessions Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lukasolson @elasticmachine @kibana-ci @drewdaemon @TinaHeiligers @davismcphee @kibanamachine