Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Make the alerts table in cases GA #154626

Merged
merged 4 commits into from
Apr 11, 2023

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Apr 7, 2023

Summary

Security solution changed recently their alert tables to the alert table provided by ResponseOps. For this reason, I removed the experimental badge from the cases alerts table in the security solution and mark it as GA.

For maintainers

@cnasikas cnasikas added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature labels Apr 7, 2023
@cnasikas cnasikas requested a review from a team as a code owner April 7, 2023 11:36
@cnasikas cnasikas self-assigned this Apr 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@cnasikas cnasikas added release_note:skip Skip the PR/issue when compiling release notes v8.8.0 labels Apr 7, 2023
@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #2 / Detection rules, bulk edit of rule actions Restricted action privileges User with no privileges can't add rule actions

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Will we do another iteration to remove the isExperimental flag and the dead code?

@cnasikas
Copy link
Member Author

LGTM! Will we do another iteration to remove the isExperimental flag and the dead code?

Thanks, Sergi! If you mean inside the cases' code, no because we would need it for cases in the stack management in the future.

@cnasikas cnasikas merged commit c1de7aa into elastic:main Apr 11, 2023
@cnasikas cnasikas deleted the remove_experimental_sec_solution branch April 11, 2023 14:32
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants