Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data.search] Update routes to not accept query #154869

Merged
merged 4 commits into from
Apr 13, 2023

Conversation

lukasolson
Copy link
Member

@lukasolson lukasolson commented Apr 12, 2023

Summary

Part of #153726.

Cleans up the search cancelation API (DELETE /internal/search/{strategy}/{id}) to not accept a query (which wasn't used anywhere anyway).

Also cleans up the search submission API (POST /internal/search/{strategy}/{id?}) to not accept a query (which also wasn't used).

@lukasolson lukasolson added Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.8.0 labels Apr 12, 2023
@lukasolson lukasolson self-assigned this Apr 12, 2023
@lukasolson lukasolson requested review from a team as code owners April 12, 2023 19:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@lukasolson lukasolson changed the title [data.search] Update DELETE route to not accept query [data.search] Update routes to not accept query Apr 12, 2023
@lukasolson lukasolson requested a review from mattkime April 12, 2023 23:17
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes lgtm

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #58 / lens app - group 3 lens reporting PDF report should be able to download report of the current visualization
  • [job] [logs] FTR Configs #58 / lens app - group 3 lens reporting PDF report should enable curl reporting if the visualization is saved
  • [job] [logs] FTR Configs #58 / lens app - group 3 lens reporting PDF report should not allow to download reports for incomplete visualization
  • [job] [logs] FTR Configs #58 / lens app - group 3 lens reporting PDF report should produce a valid URL for reporting
  • [job] [logs] FTR Configs #58 / lens app - group 3 lens reporting PDF report should show a warning message for curl reporting of unsaved visualizations

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukasolson

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukasolson lukasolson merged commit fb44beb into elastic:main Apr 13, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants