Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Posture] Vul mgmt flyout details panel #154873

Merged
merged 5 commits into from
Apr 17, 2023

Conversation

Omolola-Akinleye
Copy link
Contributor

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Screen Shot 2023-04-12 at 5 04 30 PM

Screen Shot 2023-04-12 at 5 30 55 PM

Screen Shot 2023-04-12 at 5 31 09 PM

Flyou details Feature includes:

Results are fetched from the logs-cloud_security_posture.vulnerabilities-default index.
A Flyout opens when clicking the Expand Icon in the Vulnerabilities table.
The Flyout has two tabs: Overview and JSON.
The Overview tab consists of four sections: CVSS, Data source, Publish date, Description, Fixes, and Vulnerability Scores

TODO
Add pagination in follow up pr
Add unit tests

@Omolola-Akinleye Omolola-Akinleye added backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:Cloud Security Cloud Security team related v8.8.0 labels Apr 12, 2023
@Omolola-Akinleye Omolola-Akinleye self-assigned this Apr 12, 2023
@Omolola-Akinleye Omolola-Akinleye requested a review from a team as a code owner April 12, 2023 22:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #21 / cases security and spaces enabled: trial Common bulk_create_attachments alert filtering should create a new attachment without alerts attached to the case on the same request

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 157 160 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 178.3KB 185.6KB +7.3KB
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Omolola-Akinleye

Comment on lines 60 to +63
css={css`
.euiBadge__text {
font-weight: 400;
font-size: ${xxsFontSize};
}
display: flex;
flex-direction: row;
align-items: center;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@kfirpeled kfirpeled requested a review from opauloh April 17, 2023 13:21
Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opauloh opauloh merged commit eb6bfd8 into elastic:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:Cloud Security Cloud Security team related v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cloud Security] [Findings] [Vulnerabilities] Vulnerability Details Flyout
4 participants