Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Migrate SCSS to emotion for data grid #155349

Merged
merged 7 commits into from
Apr 21, 2023

Conversation

walterra
Copy link
Contributor

Summary

Part of #140695.

Migrate SCSS to emotion for data grid mini histograms.

Checklist

@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes v8.8.0 labels Apr 20, 2023
@walterra walterra self-assigned this Apr 20, 2023
@walterra walterra requested review from a team as code owners April 20, 2023 07:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra changed the title [ML] Migrate SCSS to emotion for data grid mini histograms [ML] Migrate SCSS to emotion for data grid Apr 20, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 1728 1718 -10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.4MB 3.4MB -2.0KB
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 394 397 +3

Total ESLint disabled count

id before after diff
securitySolution 474 477 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson peteharverson requested review from peteharverson and removed request for alvarezmelissa87 April 21, 2023 08:31
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM.

Not related to the changes here, but I noticed that the color contrast on mouse hover for the histogram bars is much less noticeable in light theme:

image

than in dark mode:

image

The styling for dark mode is better for accessibility. Wonder if the light mode theme could be tweaked easily as part of this PR?

@walterra walterra mentioned this pull request Apr 21, 2023
13 tasks
@walterra
Copy link
Contributor Author

@peteharverson Added a note about revisiting the colors/contrast regarding accessibility to the data grid histograms meta issue: #71231

@walterra walterra merged commit dcca5a7 into elastic:main Apr 21, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 21, 2023
@walterra walterra deleted the ml-140695-migrate-scss-data-grid branch April 21, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants