-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Migrate SCSS to emotion for data grid #155349
[ML] Migrate SCSS to emotion for data grid #155349
Conversation
Pinging @elastic/ml-ui (:ml) |
…a/kibana into ml-140695-migrate-scss-data-grid
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @walterra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM.
Not related to the changes here, but I noticed that the color contrast on mouse hover for the histogram bars is much less noticeable in light theme:
than in dark mode:
The styling for dark mode is better for accessibility. Wonder if the light mode theme could be tweaked easily as part of this PR?
@peteharverson Added a note about revisiting the colors/contrast regarding accessibility to the data grid histograms meta issue: #71231 |
Summary
Part of #140695.
Migrate SCSS to emotion for data grid mini histograms.
Checklist