-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AO] Sync chart pointers on the metric threshold alert details page #155402
[AO] Sync chart pointers on the metric threshold alert details page #155402
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
@@ -22,6 +22,9 @@ jest.mock('../../../hooks/use_kibana', () => ({ | |||
useKibanaContextForPlugin: () => ({ | |||
services: { | |||
...mockStartServices, | |||
charts: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let me know if you have another idea for mocking.
I tried adding the following line to this mock:
charts: chartPluginMock.createStartContract(),
But then it gives me another error:
Test suite failed to run
TypeError: Cannot read properties of undefined (reading 'createSetup')
11 |
12 | const colors = new LegacyColorsService();
> 13 | colors.init(coreMock.createSetup().uiSettings);
| ^
14 |
15 | export const colorsServiceMock: LegacyColorsService = {
16 | createColorLookupFunction: jest.fn(colors.createColorLookupFunction.bind(colors)),
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #155354
Summary
This PR syncs chart pointers on the metric threshold alert details page.
🧪 How to test
xpack.observability.unsafe.alertDetails.metrics.enabled: true
to the Kibana config