[Enterprise Search] [Behavioral analytics] Add search to collection list #155524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemcelroy
reviewed
Apr 21, 2023
| actions.makeRequest({}); | ||
| fetchAnalyticsCollections: async ({ query }, breakpoint) => { | ||
| if (query) { | ||
| await breakpoint(200); |
There was a problem hiding this comment.
nitpick: make it a constant.
joemcelroy
reviewed
Apr 21, 2023
| @@ -50,12 +50,25 @@ export function registerAnalyticsRoutes({ | |||
| router.get( | |||
| { | |||
| path: '/internal/enterprise_search/analytics/collections', | |||
| validate: {}, | |||
There was a problem hiding this comment.
could we add a testcase for this?
joemcelroy
reviewed
Apr 21, 2023
| }, | ||
| }), | ||
| path: ['enterprise_search', 'analytics', 'collections'], | ||
| reducers: { | ||
| isSearchRequest: [ |
There was a problem hiding this comment.
do we still need isSearchRequest, now that we have searchQuery?
There was a problem hiding this comment.
We can avoid, but in that case we need to put some logic in query. Like if it's null(because we can't have undefined) that means we just fetched items, if it's empty that means we clear search. I would even split in two functions, like search and fetch, to make it more obvious. Because now when we use this functions we need to keep in mind logic besides it
yansavitski
added
release_note:skip
yansavitski
force-pushed
the
ba-add-search-list
branch
from
05a258e
to
188c94e
Compare
… requests for fetching and searching
yansavitski
force-pushed
the
ba-add-search-list
branch
from
188c94e
to
73e0b7e
Compare
yansavitski
force-pushed
the
ba-add-search-list
branch
from
08b5aae
to
f7f29ae
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
joemcelroy
approved these changes
Apr 25, 2023
nikitaindik
pushed a commit
to nikitaindik/kibana
that referenced
this pull request
Apr 25, 2023
…ist (elastic#155524) ✔️ Implement search for collection list Page ✔️ Add search query to fetch collection request ✔️ Update server-side to support new search query <img width="1162" alt="image" src="https://user-images.githubusercontent.com/17390745/233668294-0b3dd60b-a016-43dd-8362-91a368212d5c.png"> --------- Co-authored-by: Joseph McElroy <joseph.mcelroy@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✔️ Implement search for collection list Page
✔️ Add search query to fetch collection request
✔️ Update server-side to support new search query