Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency @elastic/charts to v57.0.1 (main) #155749

Merged
merged 13 commits into from
Jun 6, 2023
Merged

Update dependency @elastic/charts to v57.0.1 (main) #155749

merged 13 commits into from
Jun 6, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 25, 2023 •
edited by nickofthyme
Loading

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@elastic/charts 55.0.0 -> 57.0.1 age adoption passing confidence

Bug fixes

Release Notes

elastic/elastic-charts

v57.0.1

Compare Source

Bug Fixes
  • axes: start of week label on multilayer time axis (#2035) (9711233)
  • deps: update dependency @elastic/eui to ^77.2.0 (#2032) (93cadcb)
  • deps: update dependency @elastic/eui to v78 (#2038) (3feff2c)
  • deps: update dependency @elastic/eui to v79 (#2042) (8015830)
  • deps: update dependency @elastic/eui to v80 (#2047) (e6042f3)
  • heatmap: brushing selection values (#2028) (6a877b4)
  • heatmap: wrong axes labels on hover (#2033) (045fb03)

v57.0.0

Compare Source

Code Refactoring
BREAKING CHANGES
  • Enables stricter type option in src and could have
    unexpected changes. This release is meant to serve as a clean break
    in case any issues arise.

v56.0.1

Compare Source

v56.0.0

Compare Source

Bug Fixes
Features
BREAKING CHANGES
  • tooltip: The header property of TooltipInfo type was simplified to PointerValue as to include only relevant properties. This change is propagated to all other types using header as a TooltipValue. The TooltipInfo.values used to conditionally pass only highlighted TooltipValues when using a customTooltip and now always passes all values.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 25, 2023
@renovate renovate bot force-pushed the renovate/main-@elasticcharts branch 2 times, most recently from 9fe52d8 to 0b367f7 Compare April 26, 2023 18:57
@renovate renovate bot changed the title Update dependency @elastic/charts to v56 (main) Update dependency @elastic/charts to v57 (main) Apr 26, 2023
@renovate renovate bot force-pushed the renovate/main-@elasticcharts branch from 0b367f7 to 59d45fd Compare May 23, 2023 23:53
nickofthyme
nickofthyme reviewed May 24, 2023
View reviewed changes
...on/components/stats_table/components/metric_distribution_chart/metric_distribution_chart.tsx
Comment on lines -69 to 71
const headerFormatter: TooltipValueFormatter = (tooltipData: ChartTooltipValue) => {
const headerFormatter: TooltipHeaderFormatter = (tooltipData) => {
const xValue = tooltipData.value;
const chartPoint: MetricDistributionChartData | undefined = chartData.find(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No functional change here, the tooltipData.value still points to the x value. Just simplifies headerFormatter, see elastic/elastic-charts#1989 for more context.

@renovate
Copy link
Contributor Author

renovate bot commented May 24, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@nickofthyme nickofthyme changed the title Update dependency @elastic/charts to v57 (main) Update dependency @elastic/charts to v57.0.1 (main) May 24, 2023
@nickofthyme nickofthyme marked this pull request as ready for review May 26, 2023 15:36
@nickofthyme nickofthyme requested review from a team as code owners May 26, 2023 15:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@nickofthyme
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label May 29, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

stratoula
stratoula approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both bugs have been solved 👏

mohamedhamed-ahmed
mohamedhamed-ahmed approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infra changes LGTM!

darnautov
darnautov approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

@nickofthyme
Copy link
Contributor

Ping @elastic/security-threat-hunting-explore & @elastic/uptime

@nickofthyme
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@nickofthyme
Copy link
Contributor

@elastic/security-threat-hunting-explore & @elastic/uptime could we get a review here please and thank you. There are no breaking function changes.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.0MB 2.0MB +36.0B
profiling 287.5KB 287.5KB -7.0B
securitySolution 10.7MB 10.7MB +4.0B
total +33.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 366.3KB 366.3KB +32.0B
kbnUiSharedDeps-npmDll 6.0MB 6.0MB +6.9KB
total +6.9KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 414 418 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 498 502 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nickofthyme

stephmilovic
stephmilovic approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explore changes LGTM, thanks for the improvements!

@nickofthyme nickofthyme merged commit be24483 into main Jun 6, 2023
@nickofthyme nickofthyme deleted the renovate/main-@elasticcharts branch June 6, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme left review comments

@stratoula stratoula stratoula approved these changes

@mohamedhamed-ahmed mohamedhamed-ahmed mohamedhamed-ahmed approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

@darnautov darnautov darnautov approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@rockdaboot rockdaboot rockdaboot approved these changes

Assignees

@nickofthyme nickofthyme

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad Heatmap cursor selection on small multiples Lens: Incorrect first tick mark with custom panel time range
10 participants
@elasticmachine @nickofthyme @kibana-ci @rockdaboot @shahzad31 @darnautov @stephmilovic @mohamedhamed-ahmed @stratoula @kibanamachine