-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infrastructure UI] Adopt new saved views API #155827
Merged
tonyghiani
merged 42 commits into
elastic:main
from
tonyghiani:154725-create-saved-views-hooks
May 2, 2023
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
7b488c3
feat(infra): wip useInventoryViews
7228a31
feat(infra): extract react query config
34e8571
feat(infra): wip useInventoryViews mutations
54a5172
refactor(infra): remove currentView placeholder
a6b3809
Merge branch 'main' into 154725-create-saved-views-hooks
tonyghiani a76f79a
refactor(infra): update types
4fd307b
Merge branch 'main' into 154725-create-saved-views-hooks
tonyghiani 5f65776
refactor(infra): finalize types
f3f18a9
Merge branch 'main' into 154725-create-saved-views-hooks
tonyghiani d23b773
feat(infra): use new useInventoryView hook
c95eed3
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -β¦
kibanamachine f1ff109
fix(infra): update insertion logic for view
8d150fa
fix(infra): wait to update source
8f86912
Merge branch '154725-create-saved-views-hooks' of github.com:tonyghiaβ¦
b3265ca
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --β¦
kibanamachine d597acf
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -β¦
kibanamachine 5de74e8
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --β¦
kibanamachine 08d7b49
Merge branch 'main' into 154725-create-saved-views-hooks
tonyghiani ac20959
feat(infra): update typing Inventory Views
9cc2345
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -β¦
kibanamachine a164def
feat(infra): add useMetricsExplorerViews hook
38edf9b
feat(infra): refine types for metrics views
cd974bd
Merge branch 'main' into 154725-create-saved-views-hooks
tonyghiani b0b9f03
fix(infra): types
4092e28
tests(infra): remove legacy tests
4cfe534
tests(infra): remove exclusive tests
5a88bef
refactor(translation): remove unused translations
78df44d
refactor(translation): update toolbar types
d55002f
refactor(infra): switch to icon button for better alignment
ee872cd
refactor(infra): update test
7c8dae6
refactor(infra): update types
b526b14
refactor(infra): minor components changes
1ffd3e4
tests(infra): update views tets
cca3426
fix(infra): handle not found view with fallback to default
183b88c
fix(infra): remove memo
04ac8c7
fix(infra): fix flaky test
fa009c9
Update x-pack/plugins/infra/public/components/saved_views/manage_viewβ¦
tonyghiani 3e3cc33
Merge branch 'main' into 154725-create-saved-views-hooks
tonyghiani 6915fb5
Update x-pack/plugins/infra/public/hooks/use_inventory_views.ts
tonyghiani bcd0eb3
Update x-pack/plugins/infra/public/services/inventory_views/types.ts
tonyghiani bf3718c
Merge branch 'main' into 154725-create-saved-views-hooks
tonyghiani d881c37
Merge branch 'main' into 154725-create-saved-views-hooks
tonyghiani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Should we do this check earlier and disable the delete icon button? Maybe showing a tooltip that the default view can't be deleted if it's not clear there π€ When I tested I saw that I can still click it the delete icon and after that I see a disabled button:
Screen.Recording.2023-04-28.at.16.13.49.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spoke with @kkurstak in advance about this and I agree we could make a lot of improvements on the UX for saved views!
This work is however intended to only migrate the implementation for the saved views feature, we'll have the chance to further improve its usage when this work is finalized.