Bump moment-timezone to the latest version
#155832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
Team:Core
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-core (Team:Core) |
sabarasaba
approved these changes
Apr 26, 2023
|
@pgayvallet is there a risk in backporting to 7.17? The timezone issue also needs to be fixed for clusters that haven't upgraded to 8 yet. |
pgayvallet
added
backport:all-open
I don't know, we'll see what the CI tells us |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 27, 2023
## Summary Fix elastic#155792 Bump `moment-timezone` from `0.5.34` to `0.5.43` (latest version) to include latest timezone changes ## Release Note Fix a bug causing the latest timezone changes to not be taken into account for date formatting (e.g Mexico 2023) (cherry picked from commit 2250020)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Apr 27, 2023
## Summary Fix elastic#155792 Bump `moment-timezone` from `0.5.34` to `0.5.43` (latest version) to include latest timezone changes ## Release Note Fix a bug causing the latest timezone changes to not be taken into account for date formatting (e.g Mexico 2023) (cherry picked from commit 2250020) # Conflicts: # package.json # x-pack/plugins/license_management/__jest__/__snapshots__/license_page_header.test.js.snap # yarn.lock
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 27, 2023
# Backport This will backport the following commits from `main` to `8.8`: - [Bump `moment-timezone` to the latest version (#155832)](#155832) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Pierre Gayvallet","email":"pierre.gayvallet@elastic.co"},"sourceCommit":{"committedDate":"2023-04-27T05:44:18Z","message":"Bump `moment-timezone` to the latest version (#155832)\n\n## Summary\r\n\r\nFix https://github.com/elastic/kibana/issues/155792\r\n\r\nBump `moment-timezone` from `0.5.34` to `0.5.43` (latest version) to\r\ninclude latest timezone changes\r\n\r\n## Release Note\r\n\r\nFix a bug causing the latest timezone changes to not be taken into\r\naccount for date formatting (e.g Mexico 2023)","sha":"2250020b814e379cb4432f0bc1ff6f56dc350def","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:fix","backport:all-open","v8.8.0","v8.9.0"],"number":155832,"url":"https://github.com/elastic/kibana/pull/155832","mergeCommit":{"message":"Bump `moment-timezone` to the latest version (#155832)\n\n## Summary\r\n\r\nFix https://github.com/elastic/kibana/issues/155792\r\n\r\nBump `moment-timezone` from `0.5.34` to `0.5.43` (latest version) to\r\ninclude latest timezone changes\r\n\r\n## Release Note\r\n\r\nFix a bug causing the latest timezone changes to not be taken into\r\naccount for date formatting (e.g Mexico 2023)","sha":"2250020b814e379cb4432f0bc1ff6f56dc350def"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155832","number":155832,"mergeCommit":{"message":"Bump `moment-timezone` to the latest version (#155832)\n\n## Summary\r\n\r\nFix https://github.com/elastic/kibana/issues/155792\r\n\r\nBump `moment-timezone` from `0.5.34` to `0.5.43` (latest version) to\r\ninclude latest timezone changes\r\n\r\n## Release Note\r\n\r\nFix a bug causing the latest timezone changes to not be taken into\r\naccount for date formatting (e.g Mexico 2023)","sha":"2250020b814e379cb4432f0bc1ff6f56dc350def"}}]}] BACKPORT--> Co-authored-by: Pierre Gayvallet <pierre.gayvallet@elastic.co>
pgayvallet
added a commit
that referenced
this pull request
May 1, 2023
# Backport This will backport the following commits from `main` to `7.17`: - [Bump `moment-timezone` to the latest version (#155832)](#155832) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Pierre Gayvallet","email":"pierre.gayvallet@elastic.co"},"sourceCommit":{"committedDate":"2023-04-27T05:44:18Z","message":"Bump `moment-timezone` to the latest version (#155832)\n\n## Summary\r\n\r\nFix https://github.com/elastic/kibana/issues/155792\r\n\r\nBump `moment-timezone` from `0.5.34` to `0.5.43` (latest version) to\r\ninclude latest timezone changes\r\n\r\n## Release Note\r\n\r\nFix a bug causing the latest timezone changes to not be taken into\r\naccount for date formatting (e.g Mexico 2023)","sha":"2250020b814e379cb4432f0bc1ff6f56dc350def","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:fix","backport:all-open","v8.8.0","v8.9.0"],"number":155832,"url":"https://github.com/elastic/kibana/pull/155832","mergeCommit":{"message":"Bump `moment-timezone` to the latest version (#155832)\n\n## Summary\r\n\r\nFix https://github.com/elastic/kibana/issues/155792\r\n\r\nBump `moment-timezone` from `0.5.34` to `0.5.43` (latest version) to\r\ninclude latest timezone changes\r\n\r\n## Release Note\r\n\r\nFix a bug causing the latest timezone changes to not be taken into\r\naccount for date formatting (e.g Mexico 2023)","sha":"2250020b814e379cb4432f0bc1ff6f56dc350def"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/155969","number":155969,"state":"OPEN"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155832","number":155832,"mergeCommit":{"message":"Bump `moment-timezone` to the latest version (#155832)\n\n## Summary\r\n\r\nFix https://github.com/elastic/kibana/issues/155792\r\n\r\nBump `moment-timezone` from `0.5.34` to `0.5.43` (latest version) to\r\ninclude latest timezone changes\r\n\r\n## Release Note\r\n\r\nFix a bug causing the latest timezone changes to not be taken into\r\naccount for date formatting (e.g Mexico 2023)","sha":"2250020b814e379cb4432f0bc1ff6f56dc350def"}}]}] BACKPORT--> --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
|
This PR didn't make it into the latest build candidate of v7.17.10. Updating the labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #155792
Bump
moment-timezonefrom0.5.34to0.5.43(latest version) to include latest timezone changesRelease Note
Fix a bug causing the latest timezone changes to not be taken into account for date formatting (e.g Mexico 2023)