Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Fix complete tests sparkline #155838

Merged
merged 6 commits into from
May 4, 2023
Merged

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Apr 26, 2023

Summary

fixes #155434

Also fixed exploratory view redirect full page load prevent.

image

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 changed the title update complete viz [Synthetics] Fix complete test sparkline Apr 26, 2023
@shahzad31 shahzad31 changed the title [Synthetics] Fix complete test sparkline [Synthetics] Fix complete tests sparkline Apr 26, 2023
@shahzad31 shahzad31 marked this pull request as ready for review April 26, 2023 12:49
@shahzad31 shahzad31 requested review from a team as code owners April 26, 2023 12:49
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.8.0 labels Apr 26, 2023
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data in these visualizations don't always seem to be in sync with other parts of the page.

Screen Shot 2023-04-26 at 1 58 24 PM

Here you can see that the page has indeed detected an error, because of the errors icon. Also not pictured, but the current status is Failed.

This does resolve itself on the next sync it seems.

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke
Copy link
Contributor

Per conversations in slack, please change the word Complete to Successful.

Copy link
Contributor

@CoenWarmer CoenWarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AO Changes LGTM!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
exploratoryView 240.7KB 240.9KB +129.0B
observability 967.1KB 967.0KB -43.0B
synthetics 1.2MB 1.2MB +20.0B
total +106.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shahzad31 shahzad31 merged commit fffe57d into elastic:main May 4, 2023
@shahzad31 shahzad31 deleted the fix-viz branch May 4, 2023 09:39
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 4, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 4, 2023
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Synthetics] Fix complete tests sparkline
(#155838)](#155838)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2023-05-04T09:39:24Z","message":"[Synthetics]
Fix complete tests sparkline
(#155838)","sha":"fffe57dc1db2dc5fa993e8277f1e1ae1dfb05803","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","v8.8.0","v8.9.0"],"number":155838,"url":"#155838
Fix complete tests sparkline
(#155838)","sha":"fffe57dc1db2dc5fa993e8277f1e1ae1dfb05803"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#155838
Fix complete tests sparkline
(#155838)","sha":"fffe57dc1db2dc5fa993e8277f1e1ae1dfb05803"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Synthetics] Complete tests and errors sparklines missing
7 participants