[Fleet] Allow some agent actions for managed policies #155923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
release_note:skip
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
@elasticmachine merge upstream |
|
@nchaulet Sorry to expand the scope, I didn't see this PR was already up, but would you mind incorporating my feedback here?: #155294 (comment) 🙏 |
…quest-diagnostics-managed-policy
…hub.com:nchaulet/kibana into feature-show-request-diagnostics-managed-policy
nchaulet
changed the title
|
@jen-huang just updated my PR with that changes |
jen-huang
approved these changes
Apr 26, 2023
jen-huang
reviewed
Apr 26, 2023
| @@ -67,7 +67,7 @@ export const AgentDetailsActionMenu: React.FunctionComponent<{ | |||
| onClick={() => { | |||
| setIsReassignFlyoutOpen(true); | |||
| }} | |||
| disabled={!agent.active} | |||
| disabled={!agent.active || agentPolicy?.is_managed} | |||
There was a problem hiding this comment.
I think the UX would be less confusing if we hid these options instead of disabling them
There was a problem hiding this comment.
Sure I will make the change
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @nchaulet |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 27, 2023
(cherry picked from commit f06e55f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 27, 2023
…#156007) # Backport This will backport the following commits from `main` to `8.8`: - [[Fleet] Allow some agent actions for managed policies (#155923)](#155923) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"nicolas.chaulet@elastic.co"},"sourceCommit":{"committedDate":"2023-04-27T13:14:09Z","message":"[Fleet] Allow some agent actions for managed policies (#155923)","sha":"f06e55f500d84df9b281e912e68338e83ee9b3bc","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.8.0","v8.9.0"],"number":155923,"url":"#155923 Allow some agent actions for managed policies (#155923)","sha":"f06e55f500d84df9b281e912e68338e83ee9b3bc"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#155923 Allow some agent actions for managed policies (#155923)","sha":"f06e55f500d84df9b281e912e68338e83ee9b3bc"}}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #155294
That PR allow agent actions for managed policy:
UI Changes
Tests
I added a unit test to cover that
You can manually test that by enrolling an agent into a managed policy and check the button is enabled