-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs onboarding] Add landing page and client-side routing #155961
[Logs onboarding] Add landing page and client-side routing #155961
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
: never; | ||
}; | ||
|
||
export interface Params { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this?
navigateToKibanaUrl('/app/observabilityOnboarding/customLogs'); | ||
}; | ||
const handleClickApmSetupGuide = () => { | ||
navigateToKibanaUrl('/app/home#/tutorial/apm'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the #
needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌟
just some minor comments
Closes #154928.
Adds landing page and client-side routing. Also rearranges the logs_onboarding files into their own
custom_logs
dir.