Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs onboarding] Add landing page and client-side routing #155961

Merged
merged 4 commits into from
Apr 28, 2023

Conversation

ogupte
Copy link
Contributor

@ogupte ogupte commented Apr 27, 2023

Closes #154928.

Adds landing page and client-side routing. Also rearranges the logs_onboarding files into their own custom_logs dir.

Screenshot 2023-04-27 at 12 42 44 PM

@ogupte ogupte added release_note:skip Skip the PR/issue when compiling release notes v8.9.0 labels Apr 27, 2023
@ogupte ogupte requested a review from yngrdyn April 27, 2023 01:26
@ogupte ogupte requested a review from a team as a code owner April 27, 2023 01:26
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityOnboarding 64 35 -29

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 64.2KB 28.8KB -35.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityOnboarding 4.4KB 4.3KB -59.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

: never;
};

export interface Params {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

navigateToKibanaUrl('/app/observabilityOnboarding/customLogs');
};
const handleClickApmSetupGuide = () => {
navigateToKibanaUrl('/app/home#/tutorial/apm');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the # needed?

Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟
just some minor comments

@ogupte ogupte merged commit b09703c into elastic:main Apr 28, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Observability] Landing page for Observability onboarding
5 participants