Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Minor copyedit for Search Applications, Behavioral Analytics #156012

Merged
merged 1 commit into from
Apr 27, 2023
Merged

[Enterprise Search] Minor copyedit for Search Applications, Behavioral Analytics #156012

merged 1 commit into from
Apr 27, 2023

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo commented Apr 27, 2023 •
edited by kibanamachine
Loading

null

@leemthompo leemthompo added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:EnterpriseSearch v8.8.0 labels Apr 27, 2023
@leemthompo leemthompo requested a review from a team April 27, 2023 14:00
@leemthompo leemthompo self-assigned this Apr 27, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

kderusso
kderusso approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leemthompo leemthompo added backport and removed backport:skip This commit does not require backporting backport labels Apr 27, 2023
@leemthompo leemthompo enabled auto-merge (squash) April 27, 2023 14:13
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.3MB 2.3MB -30.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @leemthompo

@leemthompo leemthompo merged commit b8ca723 into elastic:main Apr 27, 2023
@kibanamachine kibanamachine mentioned this pull request Apr 27, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 27, 2023
@leemthompo
[Enterprise Search] Minor copyedit for Search Applications, Behaviora…
3117a40 
…l Analytics (elastic#156012)

(cherry picked from commit b8ca723)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 27, 2023
@kibanamachine @leemthompo
[8.8] [Enterprise Search] Minor copyedit for Search Applications, Beh…
da8b0a8 
…avioral Analytics (#156012) (#156032)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Enterprise Search] Minor copyedit for Search Applications,
Behavioral Analytics
(#156012)](#156012)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Liam
Thompson","email":"32779855+leemthompo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-04-27T15:03:46Z","message":"[Enterprise
Search] Minor copyedit for Search Applications, Behavioral Analytics
(#156012)","sha":"b8ca723c05a3c5d72a4fd3bb389f89ed88da3f60","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156012,"url":"#156012
Search] Minor copyedit for Search Applications, Behavioral Analytics
(#156012)","sha":"b8ca723c05a3c5d72a4fd3bb389f89ed88da3f60"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#156012
Search] Minor copyedit for Search Applications, Behavioral Analytics
(#156012)","sha":"b8ca723c05a3c5d72a4fd3bb389f89ed88da3f60"}}]}]
BACKPORT-->

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
@leemthompo leemthompo deleted the liamthompson/enterprise-search-copy branch May 24, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloanelybutsurely sloanelybutsurely sloanelybutsurely approved these changes

@kderusso kderusso kderusso approved these changes

Assignees

@leemthompo leemthompo

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@leemthompo @apmmachine @kibana-ci @kibanamachine @sloanelybutsurely @kderusso